Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded localhost prevents remote use #160

Open
jtuu opened this issue Jul 13, 2016 · 2 comments
Open

Hardcoded localhost prevents remote use #160

jtuu opened this issue Jul 13, 2016 · 2 comments

Comments

@jtuu
Copy link

jtuu commented Jul 13, 2016

It appears that some things in the client are hardcoded to connect to "localhost", which means shader-school can't be used from a remote location. More specifically "localhost:12491/changes" is what it's trying to connect to.
This could probably be fixed by creating the url dynamically like this
var url = 'http://' + window.location.host + '/changes'

With a quick search I couldn't find anything related to "/changes" in this repo, so I'm not sure if this issue is relevant to shader-school itself.

@belohlavek
Copy link

Yep, this is a problem for me too, shall I submit a pull request?

@shichongrui
Copy link

This was being caused by a dependency of shader-school, glslify-live. I have submitted a pull request to the author of that package with the fix. hughsk/glslify-live#6

Once that is merged, because it is not a breaking change it should only warrant a patch version bump and should get picked up by shader-school automatically. A simple npm install -g shader-school again will get the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants