Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Terminal button should be hidden when terminal: false #300

Open
AriPerkkio opened this issue Sep 2, 2024 · 0 comments
Open

Toggle Terminal button should be hidden when terminal: false #300

AriPerkkio opened this issue Sep 2, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers pr-welcome Accepting pull requests for this change

Comments

@AriPerkkio
Copy link
Member

Describe the bug

When terminal is disabled in metadata, the Toggle Terminal button is still visible. It just shows empty blank terminal when toggled.

Link to a StackBlitz project which shows the error

No response

Steps to reproduce

  1. Define in metadata:
---
type: lesson
title: Test
terminal: false
---
  1. Open page and click Toggle Terminal

Expected behavior

Whole Toggle Terminal button should be hidden.

Screenshots

image

Platform

  • TutorialKit version: 0.2.1

Additional context

No response
@AriPerkkio AriPerkkio added bug Something isn't working good first issue Good for newcomers pr-welcome Accepting pull requests for this change labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers pr-welcome Accepting pull requests for this change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AriPerkkio