Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Entity Too Large #223

Open
shulaoda opened this issue Sep 3, 2024 · 18 comments · May be fixed by #227
Open

Request Entity Too Large #223

shulaoda opened this issue Sep 3, 2024 · 18 comments · May be fixed by #227

Comments

@shulaoda
Copy link
Contributor

shulaoda commented Sep 3, 2024

Related to web-infra-dev/rspack#7757

Response {
  status: 413,
  statusText: 'Request Entity Too Large',
  headers: Headers {
    date: 'Tue, 03 Sep 2024 15:28:[23](https://github.com/web-infra-dev/rspack/actions/runs/10685274214/job/29620009337#step:8:24) GMT',
    'content-type': 'text/html',
    'transfer-encoding': 'chunked',
    connection: 'keep-alive',
    'report-to': '{"endpoints":[{"url":"https:\\/\\/a.nel.cloudflare.com\\/report\\/v4?s=stmTM6GJLuABGxIm8Hzh9cxxkIVV7l0BoDuw87STAicqiXlROWfb56x9RFEKLUlnNgnNC%2Bfte2oNJqpSm5z7Mg77xtTZzVs7%2FqAvJg4LL7v6G1koCUdPiQOOZy2T"}],"group":"cf-nel","max_age":604800}',
    nel: '{"success_fraction":0,"report_to":"cf-nel","max_age":604800}',
    vary: 'Accept-Encoding',
    server: 'cloudflare',
    'cf-ray': '8bd6c4f[31](https://github.com/web-infra-dev/rspack/actions/runs/10685274214/job/29620009337#step:8:32)d7d2b52-LAX',
    'alt-svc': 'h3=":443"; ma=86400'
  },
  body: ReadableStream { locked: false, state: 'readable', supportsBYOB: true },
  bodyUsed: false,
  ok: false,
  redirected: false,
  type: 'basic',
  url: 'https://pkg.pr.new/publish'
}
Error:  Unexpected token '<', "<html>
@Aslemammad
Copy link
Member

Let's see if the whitelist would solve the issue!

@shulaoda
Copy link
Contributor Author

shulaoda commented Sep 3, 2024

Let's see if the whitelist would solve the issue!

Let me try it.

@shulaoda
Copy link
Contributor Author

shulaoda commented Sep 3, 2024

It doesn't seem to work. Could you give me some help? @Aslemammad

https://github.com/web-infra-dev/rspack/actions/runs/10688061707/job/29628851013?pr=7757

@Aslemammad
Copy link
Member

I see, I'll have a closer look and let you know!

@Aslemammad
Copy link
Member

Sorry for this, the team and I are looking deep into this one!

Will keep you updated 🙌

@Aslemammad Aslemammad linked a pull request Sep 7, 2024 that will close this issue
@Aslemammad
Copy link
Member

Will be tracked here #227

@Aslemammad
Copy link
Member

@shulaoda Can you try this? To see if heavy uploads work for you!

API_URL=https://pkg.pr.new pnpm dlx pkg-pr-new@https://05ece7b9.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@227 publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'

@shulaoda
Copy link
Contributor Author

@shulaoda Can you try this? To see if heavy uploads work for you!

API_URL=https://pkg.pr.new pnpm dlx pkg-pr-new@https://05ece7b9.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@227 publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'

Okay, right now!

@shulaoda
Copy link
Contributor Author

@Aslemammad cc

{"url":"/multipart/create","statusCode":405,"statusMessage":"Method post is not allowed on this route.","message":"Method post is not allowed on this route."}

@Aslemammad
Copy link
Member

Hmm, weird, how about this?

API_URL=https://pkg.pr.new pnpm dlx pkg-pr-new@https://05ece7b9.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@c534ac2 publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'

@Aslemammad
Copy link
Member

Oh that makes sense, because it is not yet merged and it tries the old pkg.pr.new!

Sorry!

@Aslemammad
Copy link
Member

Aslemammad commented Sep 11, 2024

Can you try this?

Installing https://github.com/apps/continuous-releases-staging

And then running:

pnpm dlx pkg-pr-new@https://05ece7b9.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@227 publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'

But make sure to remove that app after trying so you don't have the staging github app.

@Aslemammad
Copy link
Member

Here's an updated command to run if you want!

pnpm dlx pkg-pr-new@https://9c821939.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@227 publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'

@shulaoda
Copy link
Contributor Author

@Aslemammad cc

Error:  publishing failed: {"url":"/publish","statusCode":500,"statusMessage":"","message":"Response closed due to connection limit"}

@Aslemammad
Copy link
Member

wow, that's so bad, I'll fork rspack and continue my investigation.

Really sorry for that.

@Aslemammad
Copy link
Member

Hey! I think I got it working now! Can you try this?

pnpm dlx pkg-pr-new@https://9772e258.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@227 publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'

Let me know so I merge and release!

@shulaoda
Copy link
Contributor Author

Let me know so I merge and release!

Looks great! 💗

@shulaoda
Copy link
Contributor Author

shulaoda commented Sep 22, 2024

But it seems that only @rspack/binding and @rspack/core can be opened normally, I don't know why 🤷

⚡️ Your npm packages are published.
@rspack/binding: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding@daf23b9
@rspack/binding-darwin-arm64: npm i https://9772e[25](https://github.com/web-infra-dev/rspack/actions/runs/10980999160/job/30488168895?pr=7757#step:8:26)8.stackblitz-cr.pages.dev/@rspack/binding-darwin-arm64@daf23b9
@rspack/binding-darwin-x64: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-darwin-x64@daf23b9
@rspack/binding-linux-arm64-gnu: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-linux-arm64-gnu@daf23b9
@rspack/binding-linux-x64-gnu: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-linux-x64-gnu@daf23b9
@rspack/binding-linux-arm64-musl: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-linux-arm64-musl@daf23b9
@rspack/binding-linux-x64-musl: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-linux-x64-musl@daf23b9
@rspack/binding-win32-arm64-msvc: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-win32-arm64-msvc@daf23b9
@rspack/binding-win[32](https://github.com/web-infra-dev/rspack/actions/runs/10980999160/job/30488168895?pr=7757#step:8:33)-ia32-msvc: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-win32-ia32-msvc@daf23b9
@rspack/binding-win32-x64-msvc: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/binding-win32-x64-msvc@daf23b9
@rspack/core: npm i https://9772e258.stackblitz-cr.pages.dev/@rspack/core@daf23b9
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants