Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing out after succesful publish #163

Closed
wKovacs64 opened this issue Jul 27, 2024 · 9 comments · Fixed by #166
Closed

Timing out after succesful publish #163

wKovacs64 opened this issue Jul 27, 2024 · 9 comments · Fixed by #166

Comments

@wKovacs64
Copy link

Hello, and thanks for your efforts on this project - very cool.

I just tried setting this up and for some reason it's timing out after publishing, but only for the pull_request event (the push event from the same commit succeeds). I set this up on another repo previously and it's not happening there.

Here's the PR:

wKovacs64/pwned#279

Any idea what would be causing this?

(Note: I added a timeout after I noticed it running forever so it would fail faster, but you can see a run I manually cancelled after almost 7 minutes here.)

@Aslemammad
Copy link
Member

Aslemammad commented Jul 27, 2024

Thank you so much for the kind words!

It's getting published but the process does not exit, right?
image

Can we try removing --yes flag from npx?

@wKovacs64
Copy link
Author

It's getting published but the process does not exit, right?

That's my understanding, yep.

Can we try removing --yes flag from npx?

Done. Still hangs after publishing, though. 😕

@Aslemammad
Copy link
Member

I'll have a look, thank you for letting me know 🙌

@Aslemammad
Copy link
Member

Aslemammad commented Jul 29, 2024

I just tried it on my fork and it's working with no issues!

https://github.com/Aslemammad/pwned/actions/runs/10142824058/job/28043119102#step:7:1

what do you think?

Can you try removing the --compact flag too?

@wKovacs64
Copy link
Author

I just tried it on my fork and it's working with no issues!

https://github.com/Aslemammad/pwned/actions/runs/10142824058/job/28043119102#step:7:1

what do you think?

Your test is invalid, as the step does exit successfully on push events in my repo, too. It's only pull_request events that hang. So try opening a PR on your fork I guess.

Can you try removing the --compact flag too?

Done, no change (still hangs).

@Aslemammad
Copy link
Member

Ohhh you're right! I forgot that case, I'll try again!

@Aslemammad
Copy link
Member

Still, it succeed! So I could not reproduce it.

Can you try this command from #166?

API_URL=https://pkg.pr.new npx pkg-pr-new@https://773145bf.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@166 publish

What this does is it just exits with process.exit when it finishes processing.

let me know.

@wKovacs64
Copy link
Author

That worked! I was able to add --yes and --compact back in, too (as expected). 👍

@Aslemammad
Copy link
Member

I appreciate that, let me merge it then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants