Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model generation inflection naming #1526

Closed
danicc097 opened this issue Apr 2, 2022 · 0 comments · Fixed by #1531
Closed

Model generation inflection naming #1526

danicc097 opened this issue Apr 2, 2022 · 0 comments · Fixed by #1531
Labels
bug Something isn't working 💻 linux 🔧 python Pull requests that update Python code
Milestone

Comments

@danicc097
Copy link
Contributor

danicc097 commented Apr 2, 2022

Version

1.12.0

What happened?

While testing python codegen, I found a rather curious output: any table that ends in "ta" gets a model that ends in "tum" due to the inflection library, so e.g. many-to-many tables are particularly affected since I already use the singular form. A manual fix like with "meta" #1217 wouldn't work for these cases

Is it possible to allow passing a list of table names to the config file to omit in inflection's Singular() instead? This way autogenerated SQL schemas will also be able to use it

What operating system are you using?

Linux

@danicc097 danicc097 added bug Something isn't working triage New issues that hasn't been reviewed labels Apr 2, 2022
@kyleconroy kyleconroy added 🔧 python Pull requests that update Python code 💻 linux and removed triage New issues that hasn't been reviewed labels Apr 3, 2022
@kyleconroy kyleconroy added this to the v1.14.0 milestone Apr 3, 2022
@kyleconroy kyleconroy modified the milestones: v1.14.0, v1.15.0 Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 💻 linux 🔧 python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants