-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md Guide Lacking "make" Instruction #504
Comments
The documentation refers to npm commands which are defined in the package.json file in the root directory which is common for npm modules. The npm commands can contain one or more system commands to perform the action. Make is performed when using npm run build and npm run rebuild. Hope this helps. |
Thanks, that's what I expected, but I used the dev container and ran the |
This sounds a little bit like my first experience building sql.js here: #526 Perhaps the instructions should clarify that an initial |
oddly,
then,
After that I ran |
As a non-developer wanting to add FTS-5 support to my own build, I followed the instructions in https://github.com/sql-js/sql.js/blob/master/CONTRIBUTING.md and noted that:
$ npm test
to ensure all tests pass") fails;make
to actually build the distribution assets.Is there any particular reason why there is no explicit instruction to run
make
? This would be useful for folk who aren't developers but who may want to make use of asql.js
build with some custom sqlite extensions if there are exact and complete instructions available to do so. (The containerised build really helps in that respect.)The text was updated successfully, but these errors were encountered: