fix rt query parameter and rt new data format #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josebolos it appears Travis failed because no Node environment was set. Is this something I can fix on my end? |
|
Hi @derekshull Thanks for contributing to boomcatch, this is great! The reason the tests in Travis are failing is because the changes in this PR break some of the unit tests. You can see the details of the test run here: Your PR tries to address two different problems - we usually ask people to submit different PRs for different issues, as it makes it easier to revert changes in case something goes wrong. Do you have the time and energy for submitting separate PRs with their respective unit tests? It will be greatly appreciated. Thanks again! |
hchhabada
added a commit
to hchhabada/boomcatch
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #49 and #83