Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerminalUI full screen off on windows #1041

Closed
Tracked by #761
jvalkeal opened this issue Apr 13, 2024 · 1 comment
Closed
Tracked by #761

TerminalUI full screen off on windows #1041

jvalkeal opened this issue Apr 13, 2024 · 1 comment
Milestone

Comments

@jvalkeal
Copy link
Contributor

Running catalog app on windows terminals misses menubar. As seen from screenshot it looks like it's off vertically by one line.

catalog-wrong-draw

Notice empty line at bottom. Logs shows that everything is drawn in correct positions so issue may be somewhere within jline's windows related terminal classes. Almost feels like one extra line is always drawn thus moving everything up one line thus menubar goes off screen.

This is same on cmd and powershell. Using jna vs. jansi doesn't make difference.

@jvalkeal
Copy link
Contributor Author

jvalkeal commented Apr 13, 2024

Looks like this boils down to:

https://github.com/jline/jline3/blob/19c031c0bccaeea6a4346bc82c04c7bd3ec18888/terminal/src/main/java/org/jline/utils/Display.java#L310-L312

If I modify that particular section so that last row will not write that extra space and backspace things on a screen will look normal. This section looks to be executed on windows but not sure on what terminals will also get there.

As short term we could fork jline's Display class and experiment fix and then try to contribute back to jline.

catalog-correct-draw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant