Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Allow custom subscription name for Pub/Sub healthcheck #2630

Closed
elefeint opened this issue Jan 25, 2021 · 2 comments
Closed

Allow custom subscription name for Pub/Sub healthcheck #2630

elefeint opened this issue Jan 25, 2021 · 2 comments

Comments

@elefeint
Copy link
Contributor

Currently, the Pub/Sub healthcheck attempts a pull from a nonexistent subscription. This has two negative consequences:

  1. The pull takes longer
  2. Error logs get polluted

Allowing a pull from a known existing subscription would ameliorate issues like #2628 and #2570.

@ThusithaDJ
Copy link

Hi @elefeint, I'm aware this bug has been created a couple of days before. But I would like to contribute to the spring community If this not an urgent issue.

@elefeint
Copy link
Contributor Author

elefeint commented Feb 1, 2021

@ThusithaDJ Thank you! I've recreated the issue in our new repo -- GoogleCloudPlatform/spring-cloud-gcp#236 . You'll find more information about what this task entails there.

I will close this issue, and we can continue the conversation on the new issue -- feel free to ask any questions that will help you.

@elefeint elefeint closed this as completed Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants