Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance time interval selector #380

Open
janiemi opened this issue Jul 12, 2024 · 0 comments
Open

Enhance time interval selector #380

janiemi opened this issue Jul 12, 2024 · 0 comments

Comments

@janiemi
Copy link
Contributor

janiemi commented Jul 12, 2024

Here are some possible ideas for enhancing the time interval selection component. The ones found worth implementing could be split into issues of their own.

  1. Disallow specifying an interval with From after To, at least in the Advanced input, as it would produce no results.
  2. In the Simple input, also allow formats YYYY-MM and YYYY-MM-DD hh:mm, even though the input hint probably has no space for a longer text. (YYYY-MM worked in a previous implementation.)
  3. Could the values entered in the Advanced input be copied to the Simple input fields? (Or are they already after the most recent changes?)
  4. Would it be feasible to disallow invalid Simple input or at least notify the user? In such cases, a previous implementation showed “Invalid date” as the Advanced value.
  5. Would it also make sense to disallow syntactically correct Simple input that is outside the span of time covered by the selected corpora, or notify the user?
  6. If a time interval is specified in a search and the selected corpora are changed so that the specified interval is not within the span of time covered by the newly selected corpora, would it make sense to reset the time interval to the span covered by the corpora? Or would it only confuse the user who may have altered the corpus selection in a way they did not intend and who may then re-select the previous corpora?
  7. When a time interval selector is open and the UI language is changed, the names of months and days of week in the Advanced input are still shown in the previous UI language. They are only changed on re-opening the time interval selector (selecting a different attribute and then re-selecting time interval). Would it be possible to re-localize them immediately on UI language change?

The “previous implementation” mentioned above is one in which the code for the time interval selector was in a dateInterval component(?) in app/custom/extended.js in the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant