Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: Remove globals #369

Open
26 of 48 tasks
Tracked by #374
arildm opened this issue Jun 17, 2024 · 0 comments
Open
26 of 48 tasks
Tracked by #374

Rewrite: Remove globals #369

arildm opened this issue Jun 17, 2024 · 0 comments
Labels
maintenance Oiling the gears, preventing future problems
Milestone
Rewrite to Vue

Comments

@arildm
Copy link
Member

arildm commented Jun 17, 2024 •
edited
Loading

Code components cannot be appropriately encapsulated while variables live in the global scope. This primarily means properties added to window, but also $rootScope to some extension. Some usage may still be valid, especially of the latter.

window

  • settings
  • c
  • moment
  • CSV
  • currentMode
  • currentModeParallel
  • lang
  • loc_data
  • korpApp
  • authenticationProxy
  • Rickshaw
  • model
  • statisticsService
  • util
  • CorpusListing
  • ParallelCorpusListing
  • search()
  • locationSearch()
  • safeApply()
  • regescape()
  • unregescape()
  • __
  • _graph
  • xaxis
  • CQP
  • onHashChange()

$rootScope

  • _settings
  • simpleCQP
  • extendedCQP
  • globalFilter
  • globalFilterDef
  • locationSearch()
  • searchtabs()
  • _loc
  • kwicTabs
  • compareTabs
  • graphTabs
  • mapTabs
  • textTabs
  • waitForLogin
  • openErrorModal()
  • lang
  • loc_data
  • isPopoverOpen
  • show_modal
  • jsonUrl
  • searches
  • ($on, $watch, $broadcast)
@arildm arildm added the maintenance Oiling the gears, preventing future problems label Jun 17, 2024
@arildm arildm mentioned this issue Jun 17, 2024
Open
5 tasks
@arildm arildm added this to the Rewrite to Vue milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Oiling the gears, preventing future problems
Projects
None yet
Milestone
Rewrite to Vue
Development

No branches or pull requests
1 participant
@arildm