Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reimplement Bitpacking::unpack_single #42

Merged
merged 17 commits into from
Jul 3, 2024
Merged

reimplement Bitpacking::unpack_single #42

merged 17 commits into from
Jul 3, 2024

Conversation

lwwmanning
Copy link
Member

The previous implementation was a placeholder implementation that would unpack all 1024 elements on every call to unpack_single.

@lwwmanning lwwmanning requested a review from gatesn July 1, 2024 22:23
gatesn
gatesn reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@gatesn gatesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what the ASM would look like if you also made index a const generic? Would code size blow up a lot? I have a feeling it would collapse down to ~5 instructions per index.

@lwwmanning lwwmanning enabled auto-merge (squash) July 3, 2024 16:47
@lwwmanning lwwmanning merged commit 77f3ab5 into develop Jul 3, 2024
2 checks passed
@lwwmanning lwwmanning deleted the wm/unpack-single branch July 3, 2024 16:48
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Merged
robert3005 pushed a commit that referenced this pull request Jul 4, 2024
@github-actions
chore: release v0.1.6 (#41)
7dae57e 
## 🤖 New release
* `fastlanes`: 0.1.5 -> 0.1.6

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.1.6](v0.1.5...v0.1.6) -
2024-07-03

### Other
- reimplement Bitpacking::unpack_single
([#42](#42))
- clippy works now, and is pedantic
([#38](#38))
- aggressive clippy
([#37](#37))
- pin nightly-2024-06-19
([#36](#36))
- Apache license ([#34](#34))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@robert3005 robert3005 mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatesn gatesn gatesn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwwmanning @gatesn