Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameError: name 'get_modification_time' is not defined #93

Open
rohanbanerjee opened this issue May 28, 2024 · 4 comments
Open

NameError: name 'get_modification_time' is not defined #93

rohanbanerjee opened this issue May 28, 2024 · 4 comments

Comments

@rohanbanerjee
Copy link
Contributor

I am using the latest version of the manual-correction software, SHA - 7242702d1c8d40e5ea820d2b4c4cc0c852e49c43.
I am getting the error NameError: name 'get_modification_time' is not defined while running it. I do understand the functionality of it but I'm curious why it was included there without defining the function or am I missing out on something here.

If it was not defined then I can make a function get_modification_time in utils.py and call it here.

@NathanMolinier
Copy link
Contributor

NathanMolinier commented May 28, 2024

It looks like this error was introduced by the last commit 7242702 and you seem to be the co-author here ahah

Related to this PR: #88

If you know what this function was supposed to do, I think you are the most suited for the task.

@valosekj
Copy link
Member

Thanks for reporting this, @rohanbanerjee. I have a feeling that #88 was not properly tested before merging. Especially after this merge commit (39acd0f).

I can still see an option to revert the PR:

image

So maybe we can revert the merge, which will make main work again. And after proper testing, the PR could be remerged. Any ideas?

@rohanbanerjee
Copy link
Contributor Author

Yup that sounds good. I have opened a PR to revert the changes. Will make fresh changes and open another PR for the same.

@valosekj
Copy link
Member

Reverted now by #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants