Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sidebar hide #921

Closed
wants to merge 7 commits into from
Closed

Conversation

VishnuSanal
Copy link
Contributor

@VishnuSanal VishnuSanal commented Jul 31, 2024

Description

This PR fixes #903

Summary

This PR does....

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Jul 31, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Jul 31, 2024

CodSpeed Performance Report

Merging #921 will not alter performance

Comparing VishnuSanal:sidebar-hide (38fd028) with main (1d555c9)

Summary

✅ 110 untouched benchmarks

@VishnuSanal
Copy link
Contributor Author

VishnuSanal commented Aug 2, 2024

current issues:

  • the button position
  • contents under the nav bar container cannot be clicked when the nav bar is hidden

@VishnuSanal VishnuSanal marked this pull request as ready for review August 2, 2024 13:52
@VishnuSanal
Copy link
Contributor Author

this is ready for review: @sansyrox PTAL. :)

@sansyrox
Copy link
Member

sansyrox commented Aug 3, 2024

@VishnuSanal , please complete the PR checklist 😄

Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2024 2:11pm

@sansyrox
Copy link
Member

sansyrox commented Aug 3, 2024

Screenshot 2024-08-03 at 15 14 06

Hey @VishnuSanal , this PR breaks the responsiveness on mobile. Could you have a look ?

@VishnuSanal
Copy link
Contributor Author

Wait, what?! We already had a button to hide the sidebar on mobile? :O

@VishnuSanal VishnuSanal marked this pull request as draft August 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website: navgation drawer hide
2 participants