Make shared compstates copy cloneable types #5459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you can get trolled by stuff like autonetworked dictionaries not being copied on the client so you get mispredicts. Downside is this allocates on server so not sure if we can just compile this out on server or what.
ElectroJr
reviewed
Sep 23, 2024
Comment on lines
253
to
260
| getStateInit.Append($@" | ||
| {name} = new(component.{name}),"); | ||
| } | ||
| else | ||
| { | ||
| getStateInit.Append($@" | ||
| {name} = component.{name} == null ? null : new(component.{name}),"); | ||
| } |
There was a problem hiding this comment.
Only the client should have to clone for get-state (and it would only ever have to do so once per comp).
So this should somehow check is-server/is-client to avoid allocs.
And for fixture sys, its easy to manually add the checks
There was a problem hiding this comment.
I can't debug sourcegen code coz my IDE blows up but not sure if I can just get the assembly or what, I'll see if I can figure something out.
There was a problem hiding this comment.
Okay I ended up using FULL_RELEASE but somehow it blows up tests. I think on an actual server it probably doesn't matter for getstate? Alternatively I use an msbuild property like pjb said.
PJB3005
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you can get trolled by stuff like autonetworked dictionaries not being copied on the client so you get mispredicts.
Downside is this allocates on server so not sure if we can just compile this out on server or what.