{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":53432617,"defaultBranch":"master","name":"sonic-snmpagent","ownerLogin":"sonic-net","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-03-08T17:44:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/102750714?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717523269.0","currentOid":""},"activityList":{"items":[{"before":"4e19e2cb421478980750b55217845dc399073d42","after":"5fec35ff4e63e6756f99c3b199182bf7743f00d0","ref":"refs/heads/202405","pushedAt":"2024-08-24T00:07:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"[ciscoPfcExtMIB]: Remove returning first intf index if subid is empty (#322)\n\n- What I did\r\nWhen querying for PFC counters MIB cpfcIfTable if there is no interface present on the device, then there is an exception while handing get_next as the implementation tries to return the first index of an empty list.\r\nThis happens in case of VoQ chassis Supervisor where there are no interfaces present.\r\nAnytime a snmp query is made to cpfcIfTable 1.3.6.1.4.1.9.9.813.1.1, the exception message gets logged on the device.\r\n\r\n- How I did it\r\nCurrently if sub_id is None, if_range[0] is returned. IF if_range is empty array this can cause an Exception.\r\nRemoved this check to avoid returning if_range[0].\r\nThe check \"if not sub_id\" is not required here.\r\nright = bisect_right(self.if_range, sub_id) will handle if the sub_id is empty or if the if_range is empty by returning 0 index.\r\n\r\n- How to verify it\r\nVerified that no exception is logged upon query in VoQ chassis supervisor.\r\nOther platforms like Linecard, single-asic device - no Change in the SNMP result.","shortMessageHtmlLink":"[ciscoPfcExtMIB]: Remove returning first intf index if subid is empty (…"}},{"before":"5d5cfe506ac1ccf3af88e80150508d1620d16e9f","after":"1568aa5e3b1622fc4d80e7dfb8c1e1d97551c316","ref":"refs/heads/202311","pushedAt":"2024-08-12T17:01:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"Aggregate L3 errors with L2 discards for interfaces with RIF (#325)\n\nSigned-off-by: Stepan Blyschak ","shortMessageHtmlLink":"Aggregate L3 errors with L2 discards for interfaces with RIF (#325)"}},{"before":"f6529481013dbe736246e7c0b34d4851ce515c2c","after":"4e19e2cb421478980750b55217845dc399073d42","ref":"refs/heads/202405","pushedAt":"2024-08-12T08:05:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"Aggregate L3 errors with L2 discards for interfaces with RIF (#325)\n\nSigned-off-by: Stepan Blyschak ","shortMessageHtmlLink":"Aggregate L3 errors with L2 discards for interfaces with RIF (#325)"}},{"before":"a281f9ab771adaa438f01fd5394d7a73ed6bc1d6","after":"deb7b7c43c2e9fa26acbac9907443b5d6f7310d2","ref":"refs/heads/master","pushedAt":"2024-08-12T05:52:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bingwang-ms","name":null,"path":"/bingwang-ms","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/66248323?s=80&v=4"},"commit":{"message":"Aggregate L3 errors with L2 discards for interfaces with RIF (#325)\n\nSigned-off-by: Stepan Blyschak ","shortMessageHtmlLink":"Aggregate L3 errors with L2 discards for interfaces with RIF (#325)"}},{"before":"d532923d688e9e31e6a4aa5892b4daffa5368bbc","after":"a281f9ab771adaa438f01fd5394d7a73ed6bc1d6","ref":"refs/heads/master","pushedAt":"2024-07-15T20:17:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"SuvarnaMeenakshi","name":null,"path":"/SuvarnaMeenakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/50386592?s=80&v=4"},"commit":{"message":"[ciscoPfcExtMIB]: Remove returning first intf index if subid is empty (#322)\n\n- What I did\r\nWhen querying for PFC counters MIB cpfcIfTable if there is no interface present on the device, then there is an exception while handing get_next as the implementation tries to return the first index of an empty list.\r\nThis happens in case of VoQ chassis Supervisor where there are no interfaces present.\r\nAnytime a snmp query is made to cpfcIfTable 1.3.6.1.4.1.9.9.813.1.1, the exception message gets logged on the device.\r\n\r\n- How I did it\r\nCurrently if sub_id is None, if_range[0] is returned. IF if_range is empty array this can cause an Exception.\r\nRemoved this check to avoid returning if_range[0].\r\nThe check \"if not sub_id\" is not required here.\r\nright = bisect_right(self.if_range, sub_id) will handle if the sub_id is empty or if the if_range is empty by returning 0 index.\r\n\r\n- How to verify it\r\nVerified that no exception is logged upon query in VoQ chassis supervisor.\r\nOther platforms like Linecard, single-asic device - no Change in the SNMP result.","shortMessageHtmlLink":"[ciscoPfcExtMIB]: Remove returning first intf index if subid is empty (…"}},{"before":"f6529481013dbe736246e7c0b34d4851ce515c2c","after":"d532923d688e9e31e6a4aa5892b4daffa5368bbc","ref":"refs/heads/master","pushedAt":"2024-07-15T17:04:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"SuvarnaMeenakshi","name":null,"path":"/SuvarnaMeenakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/50386592?s=80&v=4"},"commit":{"message":"Modify path of python-wheels package to use bookworm (#324)\n\nModify path of python-wheels/debian package to use bookworm.\r\nSeeing the below errors in azure pipeline:\r\n\r\nWARNING: Requirement '../target/python-wheels/buster/swsssdk*-py3-*.whl' looks like a filename, but the file does not exist\r\nERROR: swsssdk*-py3-*.whl is not a valid wheel filename.\r\n- How I did it\r\nModify path of python-wheels package to use bookworm","shortMessageHtmlLink":"Modify path of python-wheels package to use bookworm (#324)"}},{"before":null,"after":"f6529481013dbe736246e7c0b34d4851ce515c2c","ref":"refs/heads/202405","pushedAt":"2024-06-04T17:47:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bingwang-ms","name":null,"path":"/bingwang-ms","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/66248323?s=80&v=4"},"commit":{"message":"snmp-subagent changes for bookworm upgrade (#313)\n\n* remove loop argument from asyncio APIs\r\n\r\n* Add test for code coverage\r\n\r\nTaken from \"commit 2dbbb5c92a25f9f4e2aa488f21e7259516dd2df5\"\r\n\r\n---------\r\n\r\nCo-authored-by: Qi Luo ","shortMessageHtmlLink":"snmp-subagent changes for bookworm upgrade (#313)"}},{"before":"204d97d549dfa8e48f65aefa298f48121e713742","after":"f6529481013dbe736246e7c0b34d4851ce515c2c","ref":"refs/heads/master","pushedAt":"2024-04-11T00:48:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"saiarcot895","name":"Saikrishna Arcot","path":"/saiarcot895","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5923875?s=80&v=4"},"commit":{"message":"snmp-subagent changes for bookworm upgrade (#313)\n\n* remove loop argument from asyncio APIs\r\n\r\n* Add test for code coverage\r\n\r\nTaken from \"commit 2dbbb5c92a25f9f4e2aa488f21e7259516dd2df5\"\r\n\r\n---------\r\n\r\nCo-authored-by: Qi Luo ","shortMessageHtmlLink":"snmp-subagent changes for bookworm upgrade (#313)"}},{"before":"4a6de8b936a50fd8b3ea6a3b9931b9c6a03b4c18","after":"204d97d549dfa8e48f65aefa298f48121e713742","ref":"refs/heads/master","pushedAt":"2024-04-11T00:34:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Update dotnet version installed to 8.0 (#314)\n\nFor the code coverage HTML files, it looks like .NET 6.0 or newer is now required. Upgrade to .NET 8.0 to get ahead of this.","shortMessageHtmlLink":"Update dotnet version installed to 8.0 (#314)"}},{"before":"03e8bcddda3b1ba14f753ff931df90090987e12a","after":"5d5cfe506ac1ccf3af88e80150508d1620d16e9f","ref":"refs/heads/202311","pushedAt":"2024-02-02T05:04:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"Set the execute bit on sysDescr_pass.py (#306)\n\n#### Why I did it\r\nSlim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact.\r\n\r\n#### How I did it\r\nSet the execute bit directly within source control\r\n\r\n#### How to verify it\r\nTesting on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.","shortMessageHtmlLink":"Set the execute bit on sysDescr_pass.py (#306)"}},{"before":"347a6e4522111111e13ee1ab4fd4e0a58adcf612","after":"03e8bcddda3b1ba14f753ff931df90090987e12a","ref":"refs/heads/202311","pushedAt":"2024-01-23T17:12:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (#303)\n\nThis happened because the MIB assumed that half the queues configured are for mcast. When create_only_config_db_buffers is set to true this is not the case\r\n\r\n**- What I did**\r\nThe ciscoSwitchQosMIB MIB assumed that all the counter are configured and that half of the configured queues are for mcast.\r\nThis is no longer true, the feature \"polling only configured ports buffer queue\" make it possible for port to not have MC counters.\r\nThis wrong assumption caused issue https://github.com/sonic-net/sonic-buildimage/issues/17448\r\n\r\nTo fix this, I instead used the BUFFER_MAX_PARAM_TABLE to find the max possible queues\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\nInside the SNMP docker run snmp walk:\r\n$ snmpwalk -v2c -c msft 10.64.247.240 1.3.6.1.4.1.9.9.580.1.5.5.1.4.1\r\nCheck that the results is not missing counters from any queue","shortMessageHtmlLink":"Fix SNMP dropping some of the queue counter when create_only_config_d…"}},{"before":"2efaf2e9529c11155e80e637213066b82223cc70","after":"6f59d29975794e697ad6d76aabc542f9a449e59c","ref":"refs/heads/202305","pushedAt":"2024-01-20T02:31:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"StormLiangMS","name":null,"path":"/StormLiangMS","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89824293?s=80&v=4"},"commit":{"message":"Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (#303) (#309)\n\nThis happened because the MIB assumed that half the queues configured are for mcast. When create_only_config_db_buffers is set to true this is not the case\r\n\r\n**- What I did**\r\nThe ciscoSwitchQosMIB MIB assumed that all the counter are configured and that half of the configured queues are for mcast.\r\nThis is no longer true, the feature \"polling only configured ports buffer queue\" make it possible for port to not have MC counters.\r\nThis wrong assumption caused issue https://github.com/sonic-net/sonic-buildimage/issues/17448\r\n\r\nTo fix this, I instead used the BUFFER_MAX_PARAM_TABLE to find the max possible queues\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\nInside the SNMP docker run snmp walk:\r\n$ snmpwalk -v2c -c msft 10.64.247.240 1.3.6.1.4.1.9.9.580.1.5.5.1.4.1\r\nCheck that the results is not missing counters from any queue\r\n\r\nCo-authored-by: DavidZagury <32644413+DavidZagury@users.noreply.github.com>","shortMessageHtmlLink":"Fix SNMP dropping some of the queue counter when create_only_config_d…"}},{"before":"b0a4bcc750abed449f08cfe0b8759e4f58f22816","after":"2efaf2e9529c11155e80e637213066b82223cc70","ref":"refs/heads/202305","pushedAt":"2024-01-19T15:38:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"StormLiangMS","name":null,"path":"/StormLiangMS","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89824293?s=80&v=4"},"commit":{"message":"Revert \"[action] [PR:303] Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (#303)\" (#308)","shortMessageHtmlLink":"Revert \"[action] [PR:303] Fix SNMP dropping some of the queue counter…"}},{"before":null,"after":"eae87ff64fd1df39754cf17383e62fc134b9302f","ref":"refs/heads/revert-304-cherry/202305/303","pushedAt":"2024-01-19T15:33:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"StormLiangMS","name":null,"path":"/StormLiangMS","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89824293?s=80&v=4"},"commit":{"message":"Revert \"[action] [PR:303] Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (#303)\"","shortMessageHtmlLink":"Revert \"[action] [PR:303] Fix SNMP dropping some of the queue counter…"}},{"before":"e5fd19294dce62ce256e3a27d786a49c00e18824","after":"b0a4bcc750abed449f08cfe0b8759e4f58f22816","ref":"refs/heads/202305","pushedAt":"2024-01-18T05:01:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"Set the execute bit on sysDescr_pass.py (#306)\n\n#### Why I did it\r\nSlim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact.\r\n\r\n#### How I did it\r\nSet the execute bit directly within source control\r\n\r\n#### How to verify it\r\nTesting on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.","shortMessageHtmlLink":"Set the execute bit on sysDescr_pass.py (#306)"}},{"before":"29481f9c42c53123a88baa8a6e64cf8a4e37041f","after":"4a6de8b936a50fd8b3ea6a3b9931b9c6a03b4c18","ref":"refs/heads/master","pushedAt":"2024-01-17T21:06:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Set the execute bit on sysDescr_pass.py (#306)\n\n#### Why I did it\r\nSlim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact.\r\n\r\n#### How I did it\r\nSet the execute bit directly within source control\r\n\r\n#### How to verify it\r\nTesting on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.","shortMessageHtmlLink":"Set the execute bit on sysDescr_pass.py (#306)"}},{"before":"17a8bb205d2fddce8b645a990115ef2cc81c9f05","after":"a201154a17e06ffabd1d902a0e8cbe7be365d18b","ref":"refs/heads/202205","pushedAt":"2024-01-09T22:23:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (#303) (#305)\n\nThis happened because the MIB assumed that half the queues configured are for mcast. When create_only_config_db_buffers is set to true this is not the case\r\n\r\n**- What I did**\r\nThe ciscoSwitchQosMIB MIB assumed that all the counter are configured and that half of the configured queues are for mcast.\r\nThis is no longer true, the feature \"polling only configured ports buffer queue\" make it possible for port to not have MC counters.\r\nThis wrong assumption caused issue https://github.com/sonic-net/sonic-buildimage/issues/17448\r\n\r\nTo fix this, I instead used the BUFFER_MAX_PARAM_TABLE to find the max possible queues\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\nInside the SNMP docker run snmp walk:\r\n$ snmpwalk -v2c -c msft 10.64.247.240 1.3.6.1.4.1.9.9.580.1.5.5.1.4.1\r\nCheck that the results is not missing counters from any queue\r\n\r\nCo-authored-by: DavidZagury <32644413+DavidZagury@users.noreply.github.com>","shortMessageHtmlLink":"Fix SNMP dropping some of the queue counter when create_only_config_d…"}},{"before":"f9849f057ea8a10ec10bb8258db0ca364f282858","after":"e5fd19294dce62ce256e3a27d786a49c00e18824","ref":"refs/heads/202305","pushedAt":"2024-01-09T05:01:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (#303)\n\nThis happened because the MIB assumed that half the queues configured are for mcast. When create_only_config_db_buffers is set to true this is not the case\r\n\r\n**- What I did**\r\nThe ciscoSwitchQosMIB MIB assumed that all the counter are configured and that half of the configured queues are for mcast.\r\nThis is no longer true, the feature \"polling only configured ports buffer queue\" make it possible for port to not have MC counters.\r\nThis wrong assumption caused issue https://github.com/sonic-net/sonic-buildimage/issues/17448\r\n\r\nTo fix this, I instead used the BUFFER_MAX_PARAM_TABLE to find the max possible queues\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\nInside the SNMP docker run snmp walk:\r\n$ snmpwalk -v2c -c msft 10.64.247.240 1.3.6.1.4.1.9.9.580.1.5.5.1.4.1\r\nCheck that the results is not missing counters from any queue","shortMessageHtmlLink":"Fix SNMP dropping some of the queue counter when create_only_config_d…"}},{"before":"3b6a4ad338adc0044331b70fc1e6cd589f152829","after":"29481f9c42c53123a88baa8a6e64cf8a4e37041f","ref":"refs/heads/master","pushedAt":"2024-01-09T01:55:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (#303)\n\nThis happened because the MIB assumed that half the queues configured are for mcast. When create_only_config_db_buffers is set to true this is not the case\r\n\r\n**- What I did**\r\nThe ciscoSwitchQosMIB MIB assumed that all the counter are configured and that half of the configured queues are for mcast.\r\nThis is no longer true, the feature \"polling only configured ports buffer queue\" make it possible for port to not have MC counters.\r\nThis wrong assumption caused issue https://github.com/sonic-net/sonic-buildimage/issues/17448\r\n\r\nTo fix this, I instead used the BUFFER_MAX_PARAM_TABLE to find the max possible queues\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\nInside the SNMP docker run snmp walk:\r\n$ snmpwalk -v2c -c msft 10.64.247.240 1.3.6.1.4.1.9.9.580.1.5.5.1.4.1\r\nCheck that the results is not missing counters from any queue","shortMessageHtmlLink":"Fix SNMP dropping some of the queue counter when create_only_config_d…"}},{"before":null,"after":"347a6e4522111111e13ee1ab4fd4e0a58adcf612","ref":"refs/heads/202311","pushedAt":"2023-12-21T18:21:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yxieca","name":"Ying Xie","path":"/yxieca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18753401?s=80&v=4"},"commit":{"message":"Improve MIBUpdater to re-connect DBConnector when re-init data. (#290)\n\nImprove MIBUpdater to re-connect DBConnector when re-init data.\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 24705208\r\n\r\n**- What I did**\r\nFix when redis restart, some MIBUpdater's db connection will broken and keeps report error to syslog issue.\r\n\r\nThere will be following message repeat in syslog:\r\n```\r\n#012 File \"/usr/local/lib/python3.7/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 674, in _update_per_namespace_data#\r\n#012 msg = pubsub.get_message()#\r\n#012 File \"/usr/lib/python3/dist-packages/swsscommon/swsscommon.py\", line 1626, in get_message#\r\n#012 return _swsscommon.PubSub_get_message(self, timeout)#\r\n#012RuntimeError: RedisError: Failed to select, err=3: errstr=Server closed the connection\r\n```\r\n\r\n**- How I did it**\r\nRe-connect DBConnector in every MIBUpdater's reinit_data method.\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\nManually test with following steps:\r\n1. in database container kill redis server.\r\n2. start redis in database container later: service redis-server start\r\n2. check syslog, confirm following log exist but now new log few minutes later after mibs re-init:\r\n\r\nsudo cat /var/log/syslog | grep rfc2737.py | grep PubSub_get_message\r\n\r\nSep 22 03:30:17.223944 vlab-01 ERR snmp#snmp-subagent [ax_interface] ERROR: MIBUpdater.start() caught an unexpected exception during update_data()#012Traceback (most recent call last):#012 File \"/usr/local/lib/python3.9/dist-packages/ax_interface/mib.py\", line 43, in start#012 self.update_data()#012 File \"/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 326, in update_data#012 updater.update_data(i, self.statedb[i])#012 File \"/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 666, in update_data#012 self._update_per_namespace_data(self.pub_sub_dict[db_index])#012 File \"/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 675, in _update_per_namespace_data#012 msg = pubsub.get_message()#012 File \"/usr/lib/python3/dist-packages/swsscommon/swsscommon.py\", line 1996, in get_message#012 return _swsscommon.PubSub_get_message(self, timeout, interrupt_on_signal)#012RuntimeError: RedisError: Failed to select, err=3: errstr=Server closed the connection\r\n\r\n\r\n**- Description for the changelog**\r\nImprove MIBUpdater to re-connect DBConnector when re-init data.","shortMessageHtmlLink":"Improve MIBUpdater to re-connect DBConnector when re-init data. (#290)"}},{"before":"57ee4b9216efd74fb1de83026dddbc212dc79ed8","after":"f9849f057ea8a10ec10bb8258db0ca364f282858","ref":"refs/heads/202305","pushedAt":"2023-12-15T23:01:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mssonicbld","name":null,"path":"/mssonicbld","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79238446?s=80&v=4"},"commit":{"message":"Enable faulthandler to provide more fault information (#301)\n\nEnable faulthandler to provide more fault information.\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 17637258\r\n\r\n**- What I did**\r\nEnable faulthandler to provide more fault information.\r\n\r\n**- How I did it**\r\nEnable faulthandler when snmp-subagent startup.\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nEnable faulthandler to provide more fault information.","shortMessageHtmlLink":"Enable faulthandler to provide more fault information (#301)"}},{"before":"77e93742ef35cfad0d0ceeacd73db25d19c86379","after":"5a73df0d0e1fa9ed6e3997f039d00378b33b6967","ref":"refs/heads/202012","pushedAt":"2023-12-02T01:12:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Enable faulthandler to provide more fault information (#301)\n\nEnable faulthandler to provide more fault information.\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 17637258\r\n\r\n**- What I did**\r\nEnable faulthandler to provide more fault information.\r\n\r\n**- How I did it**\r\nEnable faulthandler when snmp-subagent startup.\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nEnable faulthandler to provide more fault information.","shortMessageHtmlLink":"Enable faulthandler to provide more fault information (#301)"}},{"before":"347a6e4522111111e13ee1ab4fd4e0a58adcf612","after":"3b6a4ad338adc0044331b70fc1e6cd589f152829","ref":"refs/heads/master","pushedAt":"2023-11-22T05:27:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"liuh-80","name":"Hua Liu","path":"/liuh-80","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/58683130?s=80&v=4"},"commit":{"message":"Enable faulthandler to provide more fault information (#301)\n\nEnable faulthandler to provide more fault information.\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 17637258\r\n\r\n**- What I did**\r\nEnable faulthandler to provide more fault information.\r\n\r\n**- How I did it**\r\nEnable faulthandler when snmp-subagent startup.\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nEnable faulthandler to provide more fault information.","shortMessageHtmlLink":"Enable faulthandler to provide more fault information (#301)"}},{"before":"bdaddca5db1a4b7071c05bdff324257685e889d6","after":"347a6e4522111111e13ee1ab4fd4e0a58adcf612","ref":"refs/heads/master","pushedAt":"2023-10-30T03:24:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"liuh-80","name":"Hua Liu","path":"/liuh-80","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/58683130?s=80&v=4"},"commit":{"message":"Improve MIBUpdater to re-connect DBConnector when re-init data. (#290)\n\nImprove MIBUpdater to re-connect DBConnector when re-init data.\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 24705208\r\n\r\n**- What I did**\r\nFix when redis restart, some MIBUpdater's db connection will broken and keeps report error to syslog issue.\r\n\r\nThere will be following message repeat in syslog:\r\n```\r\n#012 File \"/usr/local/lib/python3.7/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 674, in _update_per_namespace_data#\r\n#012 msg = pubsub.get_message()#\r\n#012 File \"/usr/lib/python3/dist-packages/swsscommon/swsscommon.py\", line 1626, in get_message#\r\n#012 return _swsscommon.PubSub_get_message(self, timeout)#\r\n#012RuntimeError: RedisError: Failed to select, err=3: errstr=Server closed the connection\r\n```\r\n\r\n**- How I did it**\r\nRe-connect DBConnector in every MIBUpdater's reinit_data method.\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\nManually test with following steps:\r\n1. in database container kill redis server.\r\n2. start redis in database container later: service redis-server start\r\n2. check syslog, confirm following log exist but now new log few minutes later after mibs re-init:\r\n\r\nsudo cat /var/log/syslog | grep rfc2737.py | grep PubSub_get_message\r\n\r\nSep 22 03:30:17.223944 vlab-01 ERR snmp#snmp-subagent [ax_interface] ERROR: MIBUpdater.start() caught an unexpected exception during update_data()#012Traceback (most recent call last):#012 File \"/usr/local/lib/python3.9/dist-packages/ax_interface/mib.py\", line 43, in start#012 self.update_data()#012 File \"/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 326, in update_data#012 updater.update_data(i, self.statedb[i])#012 File \"/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 666, in update_data#012 self._update_per_namespace_data(self.pub_sub_dict[db_index])#012 File \"/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/ietf/rfc2737.py\", line 675, in _update_per_namespace_data#012 msg = pubsub.get_message()#012 File \"/usr/lib/python3/dist-packages/swsscommon/swsscommon.py\", line 1996, in get_message#012 return _swsscommon.PubSub_get_message(self, timeout, interrupt_on_signal)#012RuntimeError: RedisError: Failed to select, err=3: errstr=Server closed the connection\r\n\r\n\r\n**- Description for the changelog**\r\nImprove MIBUpdater to re-connect DBConnector when re-init data.","shortMessageHtmlLink":"Improve MIBUpdater to re-connect DBConnector when re-init data. (#290)"}},{"before":"622b77196a970c268ea665a2f78fce513c016aa1","after":"8b9cab7d0fa2d9594db10a71cc5a7e347279ae04","ref":"refs/heads/201911","pushedAt":"2023-10-26T00:42:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"[201911] Fix IfHighSpeed UT issue on 201911 (#299)\n\nFix IfHighSpeed UT issue on 201911\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 25199873\r\n\r\n**- What I did**\r\nFix IfHighSpeed UT issue on 201911\r\n\r\n**- How I did it**\r\nFix UT backport issue by change string to binary, which caused by this change in 202012:\r\nhttps://github.com/liuh-80/sonic-snmpagent/commit/57e54d9561934b853a44185bbb401207f4503292#diff-8b42be2a8bea9f0ba1ac57afd853dc86afbdb80a8e31b959278b041b71431119\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nFix IfHighSpeed UT issue on 201911","shortMessageHtmlLink":"[201911] Fix IfHighSpeed UT issue on 201911 (#299)"}},{"before":"f91a9e6e07a43cae531cda019935de3221e0bb09","after":"622b77196a970c268ea665a2f78fce513c016aa1","ref":"refs/heads/201911","pushedAt":"2023-10-20T22:59:21.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Fix backup port rfc2863 UT to 202012 branch issue (#298)\n\nFix IfHighSpeed UT issue on 202012\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 25199873\r\n\r\n**- What I did**\r\nFix IfHighSpeed UT issue on 202012\r\n\r\n**- How I did it**\r\nFix UT backport issue by remove unnecessary mock data.\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nFix IfHighSpeed UT issue on 202012","shortMessageHtmlLink":"Fix backup port rfc2863 UT to 202012 branch issue (#298)"}},{"before":"4622b8df01e6cfa818568b5a78a1a56ab555097d","after":"57ee4b9216efd74fb1de83026dddbc212dc79ed8","ref":"refs/heads/202305","pushedAt":"2023-10-17T13:11:38.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"StormLiangMS","name":null,"path":"/StormLiangMS","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89824293?s=80&v=4"},"commit":{"message":"Add ifhighspeed UT (#296)\n\nAdd unit test for IfHighSpeed with PortChannel with no member ports\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 25199873\r\n\r\n**- What I did**\r\nAdd new UT cover InterfaceMIBUpdater.get_high_speed(), this will fix issue: https://github.com/sonic-net/sonic-snmpagent/issues/294\r\n\r\n**- How I did it**\r\nAdd new UT and mock data to test InterfaceMIBUpdater.get_high_speed() with PortChannel with no member ports\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nAdd unit test of IfHighSpeed with PortChannel with no member ports","shortMessageHtmlLink":"Add ifhighspeed UT (#296)"}},{"before":"1477c368369db44f9a2f9deac0356bbd5fad6364","after":"17a8bb205d2fddce8b645a990115ef2cc81c9f05","ref":"refs/heads/202205","pushedAt":"2023-10-13T17:30:19.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"yxieca","name":"Ying Xie","path":"/yxieca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18753401?s=80&v=4"},"commit":{"message":"Add ifhighspeed UT (#296)\n\nAdd unit test for IfHighSpeed with PortChannel with no member ports\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 25199873\r\n\r\n**- What I did**\r\nAdd new UT cover InterfaceMIBUpdater.get_high_speed(), this will fix issue: https://github.com/sonic-net/sonic-snmpagent/issues/294\r\n\r\n**- How I did it**\r\nAdd new UT and mock data to test InterfaceMIBUpdater.get_high_speed() with PortChannel with no member ports\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nAdd unit test of IfHighSpeed with PortChannel with no member ports","shortMessageHtmlLink":"Add ifhighspeed UT (#296)"}},{"before":"2cb824184483f76364b2300ae749c8fe71783eef","after":"77e93742ef35cfad0d0ceeacd73db25d19c86379","ref":"refs/heads/202012","pushedAt":"2023-10-13T05:34:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Fix backup port rfc2863 UT to 202012 branch issue (#298)\n\nFix IfHighSpeed UT issue on 202012\r\n\r\n#### Work item tracking\r\nMicrosoft ADO (number only): 25199873\r\n\r\n**- What I did**\r\nFix IfHighSpeed UT issue on 202012\r\n\r\n**- How I did it**\r\nFix UT backport issue by remove unnecessary mock data.\r\n\r\n**- How to verify it**\r\nPass all UT\r\n\r\n**- Description for the changelog**\r\nFix IfHighSpeed UT issue on 202012","shortMessageHtmlLink":"Fix backup port rfc2863 UT to 202012 branch issue (#298)"}},{"before":null,"after":"4622b8df01e6cfa818568b5a78a1a56ab555097d","ref":"refs/heads/202305","pushedAt":"2023-10-12T23:44:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"qiluo-msft","name":"Qi Luo","path":"/qiluo-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11406616?s=80&v=4"},"commit":{"message":"Fix: zero route may have empty nexthop (#276)\n\n**- What I did**\r\nFix: zero route may have empty nexthop. Improve code robustness.\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\nManual test:\r\n1. manipulate ApplDB default route: remove nexthop field and value\r\n2. recover\r\n3. manipulate ApplDB default route: remove ifname field and value\r\n4. recover\r\n\r\nAlso add unit test.","shortMessageHtmlLink":"Fix: zero route may have empty nexthop (#276)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yNFQwMDowNzozNy4wMDAwMDBazwAAAASiz3Jk","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yNFQwMDowNzozNy4wMDAwMDBazwAAAASiz3Jk","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMC0xMlQyMzo0NDo0MC4wMDAwMDBazwAAAAOV9oMc"}},"title":"Activity · sonic-net/sonic-snmpagent"}