Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable the build:dns-fallback step from npm run generate #302

Closed
wants to merge 4 commits into from
Closed

build: enable the build:dns-fallback step from npm run generate #302

wants to merge 4 commits into from

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Aug 1, 2024

This PR is broken into a few commits:

  1. Ignore the paths of the new snapcraft remote-build logs
  2. Enable a build step we were previously skipping due to proxy issues; this required an actual patch to the source, which I will propose upstream
  3. Remove some older build patterns/cleanup stuff
  4. Add the x11/wayland plugs - not sure why these weren't already in!

@jnsgruk
Copy link
Member Author

jnsgruk commented Aug 1, 2024

Note: even without the cleanup part, I've measured the file size before/after the change and it's the same.

@jnsgruk jnsgruk closed this by deleting the head repository Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlijn-sebrechts merlijn-sebrechts Awaiting requested review from merlijn-sebrechts

@popey popey Awaiting requested review from popey

@lengau lengau Awaiting requested review from lengau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnsgruk