Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Tag Creator from Dictionary #8

Open
cagylogic opened this issue Aug 12, 2020 · 2 comments
Open

Private Tag Creator from Dictionary #8

cagylogic opened this issue Aug 12, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cagylogic
Copy link

cagylogic commented Aug 12, 2020

This is not issue. just request.

dicom.showPrivateTags is set true, (odds,00XX) tag is known as Private Creator, VR LO.
But still ?? ? = <binary data of length: are displayed.

I understand dicom.dictionary doesn't handle Private Creator. so this is skipped.

extractor.ts line# 149 around. findTagInfo(). add follows to show Private Creator.

if(/[13579bdf]/i.test(tag[4])/*isPrivateTag*/ && tag.substring(5, 7) === '00') { return { name: 'PrivateCreator', vr: 'LO'}; }

@smikitky smikitky added the bug Something isn't working label Aug 13, 2020
@smikitky smikitky self-assigned this Aug 13, 2020
@smikitky
Copy link
Owner

smikitky commented Aug 13, 2020

Thank you, I was not aware of this rule, so let me investigate.

Relevant spec: http://dicom.nema.org/medical/dicom/current/output/html/part05.html#sect_7.8

@cagylogic
Copy link
Author

cagylogic commented Aug 13, 2020

I wrote one code to support private tag rule and create Pull request.
http://dicom.nema.org/medical/dicom/current/output/html/part05.html#sect_7.8

Please refer it and think to merge or based on that, add that function.

This is my 1st pull request on GitHub. so if I did something wrong, let me know.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants