From 74c060184a9a85063edb10aa03eec5761991555a Mon Sep 17 00:00:00 2001 From: Bartek Tofel Date: Fri, 13 Sep 2024 16:44:07 +0200 Subject: [PATCH] remove Solidity Review issue from changeset to test creation of new one --- .github/scripts/jira/enforce-jira-solidity-review.ts | 2 +- contracts/.changeset/wet-monkey-signs.md | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/scripts/jira/enforce-jira-solidity-review.ts b/.github/scripts/jira/enforce-jira-solidity-review.ts index a3271a966a5..95713644caf 100644 --- a/.github/scripts/jira/enforce-jira-solidity-review.ts +++ b/.github/scripts/jira/enforce-jira-solidity-review.ts @@ -442,7 +442,7 @@ ${SOLIDITY_REVIEW_PREFIX}PROJ-1234`) */ function assertChecklistCount(checklistJSON: any, minChecklistCount: number) { if (checklistJSON.checklists) { - if (checklistJSON.checklists instanceof Array && (checklistJSON.checklists as Array).length < minChecklistCount) { + if (!(checklistJSON.checklists instanceof Array) || (checklistJSON.checklists as Array).length < minChecklistCount) { core.debug('Checklist JSON:') core.debug(JSON.stringify(checklistJSON)) throw new Error(`Checklist JSON either did not contain "checklists" array or it's lenght was smaller than ${minChecklistCount}`) diff --git a/contracts/.changeset/wet-monkey-signs.md b/contracts/.changeset/wet-monkey-signs.md index f827aebfcaf..cbc5c3fec3d 100644 --- a/contracts/.changeset/wet-monkey-signs.md +++ b/contracts/.changeset/wet-monkey-signs.md @@ -4,6 +4,4 @@ #internal test whether Solidity Review issue enforcement is working -PR issue: TT-1624 - -Solidity Review issue: TT-1649 \ No newline at end of file +PR issue: TT-1624 \ No newline at end of file