Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed Rule modification: ComposePreviewPublic should not warn if the function has VisibleForTesting or similar #379

Open
yogurtearl opened this issue Aug 8, 2024 · 0 comments
Open

Proposed Rule modification: ComposePreviewPublic should not warn if the function has VisibleForTesting or similar #379

yogurtearl opened this issue Aug 8, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@yogurtearl
Copy link

If I have a @Preview I want to use it in a screenshot test, I would want to add @VisibleForTesting and make it public.

ComposePreviewPublic still triggers in this case, but it should ignore @Preview annotated with @VisibleForTesting or similar.
@ZacSweers ZacSweers added the help wanted Extra attention is needed label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yogurtearl @ZacSweers