Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workouts #206

Open
sivertschou opened this issue Nov 5, 2022 · 0 comments
Open

Refactor workouts #206

sivertschou opened this issue Nov 5, 2022 · 0 comments
Labels
code-enhancement Improvements to the codebase

Comments

@sivertschou
Copy link
Owner

sivertschou commented Nov 5, 2022 •
edited
Loading

We need to do some major changes to how our workouts are handled, especially how workouts are duplicated/imported.

Known issues/bugs:

  1. New workouts (possibly only imported workouts) have the type: "new" field, which should only be used and stored in the frontend.
  2. We are using a counter for the ids of workouts and workoutparts. We should at least change the id of a workout to be less guessable, since everyone can import everyone's workouts at the moment.
  3. We need to include some sort of visibility for the workouts like public/private.

Since we are refactoring users, workouts would be a good next step. Major changes should not be done until the user refactor is done.
@sivertschou sivertschou added the code-enhancement Improvements to the codebase label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-enhancement Improvements to the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sivertschou