Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB 2.x, Annotations. Send tags for filtering #4197

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

Amerousful
Copy link
Contributor

@Amerousful Amerousful commented Jun 21, 2024

Initial thread in the Slack - link

Old: events title="Sitespeed.io",text="${message}",tags=${influxDBTags} ${timestamp}
New:annotations,${influxDBTags} title="Sitespeed.io",text="${message}",tags=${grafanaTags} ${timestamp}


Fixes:

  1. Send annotations also as a tags (not only as field's value)
  2. Rename events to annotations for appropriate naming.

1) Send annotations as a tags, because the current logic sends them as fields.
3) Represent tags with keys, in format key1=value1,key2=value2, instead of value1,value2.
3) Rename events to annotations for appropriate naming. However, it might not be a good idea to change it because it would be inconsistent with the underlying logic in others "senders".
image 3626

@soulgalore
Copy link
Member

Hi @Amerousful nice thank you. Can you test that you can get the annotations and match them like this:
Screenshot 2024-06-23 at 18 54 33

@Amerousful
Copy link
Contributor Author

Now it works. I realized that it turns out that the original tags were for Grafana. I returned it back, and now this logic writes both of them: for Grafana and for InfluxDB.


image 3660 image 3661 image 3659

@Amerousful Amerousful changed the title InfluxDB 2.x, Annotations. Fix: send tags not as fields. InfluxDB 2.x, Annotations. Send tags for filter Jul 24, 2024
@Amerousful Amerousful changed the title InfluxDB 2.x, Annotations. Send tags for filter InfluxDB 2.x, Annotations. Send tags for filtering Jul 24, 2024
@soulgalore soulgalore merged commit 94854aa into sitespeedio:main Jul 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants