InfluxDB 2.x, Annotations. Send tags for filtering #4197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial thread in the Slack - link
Old:
events title="Sitespeed.io",text="${message}",tags=${influxDBTags} ${timestamp}
New:
annotations,${influxDBTags} title="Sitespeed.io",text="${message}",tags=${grafanaTags} ${timestamp}
Fixes:
tags
(not only asfield
's value)events
toannotations
for appropriate naming.1) Send annotations as atags
, because the current logic sends them asfields
.3) Represent tags with keys, in formatkey1=value1,key2=value2
, instead ofvalue1,value2
.3) Renameevents
toannotations
for appropriate naming. However, it might not be a good idea to change it because it would be inconsistent with the underlying logic in others "senders".