InfluxDB 2.x - Send annotations #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amerousful
changed the title
|
Hi @Amerousful sorry for being late on this. So there's an error in the Linux browsers GitHub action can you check what's wrong? I can help out in the end of this week so it can go out, as long as it pass the tests. |
|
For the duplication of the code, I think its ok for now so we at least have something that works. |
|
@soulgalore Hi, don't worry. Got it. Do not hesitate to ask me refactoring it, in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4174
I have concerns about realization. I don't like this fact that there's two almost the same code in
lib/plugins/influxdb/send-annotation.jsandlib/plugins/influxdb/send-annotationV2.js, but I did it by analogy withlib/plugins/influxdb/sender.jsandlib/plugins/influxdb/senderV2.js. I followed the source structure.