Guard against disabling screenshots. (#4245)

#4228
sitespeedio · Jul 30, 2024 · c325357 · c325357
1 parent 4b8908e
commit c325357
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/lib/plugins/browsertime/index.js b/lib/plugins/browsertime/index.js
@@ -427,18 +427,20 @@ export default class BrowsertimePlugin extends SitespeedioPlugin {
               } else {
                 // Push all screenshots
                 run.screenshots = [];
-                for (let screenshot of result[resultIndex].files.screenshot[
-                  runIndex
-                ]) {
-                  if (
-                    screenshot.includes(
-                      `${this.resultUrls.relativeSummaryPageUrl(
-                        url,
-                        this.allAlias[url]
-                      )}data`
-                    )
-                  ) {
-                    run.screenshots.push(screenshot);
+                if (result[resultIndex].files.screenshot.length > 0) {
+                  for (let screenshot of result[resultIndex].files.screenshot[
+                    runIndex
+                  ]) {
+                    if (
+                      screenshot.includes(
+                        `${this.resultUrls.relativeSummaryPageUrl(
+                          url,
+                          this.allAlias[url]
+                        )}data`
+                      )
+                    ) {
+                      run.screenshots.push(screenshot);
+                    }
                   }
                 }
               }