From 30ba3ab87ab55e4abe11a1fb6f91a6ac756bfbaa Mon Sep 17 00:00:00 2001 From: soulgalore Date: Wed, 11 Sep 2024 09:28:37 +0200 Subject: [PATCH] Fid is removed from CRUX, remove all references --- lib/plugins/crux/index.js | 2 -- lib/plugins/crux/pug/index.pug | 10 +++------- lib/plugins/crux/repackage.js | 9 --------- 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/lib/plugins/crux/index.js b/lib/plugins/crux/index.js index 10b28ad137..483ef5a535 100644 --- a/lib/plugins/crux/index.js +++ b/lib/plugins/crux/index.js @@ -17,7 +17,6 @@ const defaultConfig = {}; const DEFAULT_METRICS_PAGESUMMARY = [ 'loadingExperience.*.FIRST_CONTENTFUL_PAINT_MS.*', - 'loadingExperience.*.FIRST_INPUT_DELAY_MS.*', 'loadingExperience.*.LARGEST_CONTENTFUL_PAINT_MS.*', 'loadingExperience.*.CUMULATIVE_LAYOUT_SHIFT_SCORE.*', 'loadingExperience.*.TIME_TO_FIRST_BYTE_MS.*', @@ -28,7 +27,6 @@ const DEFAULT_METRICS_PAGESUMMARY = [ ]; const DEFAULT_METRICS_SUMMARY = [ 'originLoadingExperience.*.FIRST_CONTENTFUL_PAINT_MS.*', - 'originLoadingExperience.*.FIRST_INPUT_DELAY_MS.*', 'originLoadingExperience.*.LARGEST_CONTENTFUL_PAINT_MS.*', 'originLoadingExperience.*.CUMULATIVE_LAYOUT_SHIFT_SCORE.*', 'originLoadingExperience.*.TIME_TO_FIRST_BYTE_MS.*', diff --git a/lib/plugins/crux/pug/index.pug b/lib/plugins/crux/pug/index.pug index fc77b90a01..ff93d628af 100644 --- a/lib/plugins/crux/pug/index.pug +++ b/lib/plugins/crux/pug/index.pug @@ -11,7 +11,7 @@ mixin sizeCell(title, size) td.number(data-title=title, data-value= size)= h.size.format(size) - const crux = pageInfo.data.crux.pageSummary; -- const metrics = {round_trip_time: 'Round trip time', experimental_time_to_first_byte: 'Time to first byte (TTFB)', first_contentful_paint:'First Contentful Paint (FCP)', largest_contentful_paint: 'Largest Contentful Paint (LCP)', first_input_delay:'First Input Delay (FID)', cumulative_layout_shift: 'Cumulative Layout Shift (CLS)', interaction_to_next_paint: 'Interaction to next paint (INP)'}; +- const metrics = {round_trip_time: 'Round trip time', experimental_time_to_first_byte: 'Time to first byte (TTFB)', first_contentful_paint:'First Contentful Paint (FCP)', largest_contentful_paint: 'Largest Contentful Paint (LCP)', cumulative_layout_shift: 'Cumulative Layout Shift (CLS)', interaction_to_next_paint: 'Interaction to next paint (INP)'}; - const experiences = ['loadingExperience','originLoadingExperience']; if experiences @@ -112,8 +112,6 @@ if experiences - let LCPs = [Number(get(crux, `${cruxus}.largest_contentful_paint.histogram[0].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.largest_contentful_paint.histogram[1].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.largest_contentful_paint.histogram[2].density`, 0)*100).toFixed(2)]; - - let FIDs = [Number(get(crux, `${cruxus}.first_input_delay.histogram[0].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.first_input_delay.histogram[1].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.first_input_delay.histogram[2].density`, 0)*100).toFixed(2)]; - - let CLSs = [Number(get(crux, `${cruxus}.cumulative_layout_shift.histogram[0].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.cumulative_layout_shift.histogram[1].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.cumulative_layout_shift.histogram[2].density`, 0)*100).toFixed(2)]; - let TTFBs = [Number(get(crux, `${cruxus}.experimental_time_to_first_byte.histogram[0].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.experimental_time_to_first_byte.histogram[1].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.experimental_time_to_first_byte.histogram[2].density`, 0)*100).toFixed(2)]; @@ -142,7 +140,6 @@ if experiences drawPie('#chartFCP#{experience + formFactor}', [#{FCPs}], ['Fast: #{FCPs[0]}%', 'Moderate #{FCPs[1]}%', 'Slow: #{FCPs[2]}%']); drawPie('#chartLCP#{experience + formFactor}', [#{LCPs}], ['Fast: #{LCPs[0]}%', 'Moderate #{LCPs[1]}%', 'Slow: #{LCPs[2]}%']); - drawPie('#chartFID#{experience + formFactor}', [#{FIDs}], ['Fast: #{FIDs[0]}%', 'Moderate #{FIDs[1]}%', 'Slow: #{FIDs[2]}%']); drawPie('#chartCLS#{experience + formFactor}', [#{CLSs}], ['Good: #{CLSs[0]}%', 'Need improvement: #{CLSs[1]}%', 'Poor: #{CLSs[2]}%']); drawPie('#chartTTFB#{experience + formFactor}', [#{TTFBs}], ['Good: #{TTFBs[0]}%', 'Need improvement: #{TTFBs[1]}%', 'Poor: #{TTFBs[2]}%']); drawPie('#chartITNP#{experience + formFactor}', [#{ITNPs}], ['Good: #{ITNPs[0]}%', 'Need improvement: #{ITNPs[1]}%', 'Poor: #{ITNPs[2]}%']); @@ -168,12 +165,11 @@ if experiences td(data-title=metrics['cumulative_layout_shift']) .ct-chart(id='chartCLS' + experience + formFactor) tr - th #{metrics['first_input_delay']} th #{metrics['interaction_to_next_paint']} + th tr - td(data-title=metrics['first_input_delay']) - .ct-chart(id='chartFID' + experience + formFactor) td(data-title=metrics['interaction_to_next_paint']) .ct-chart(id='chartITNP' + experience + formFactor) + td else p No data availible in the Chrome User Experience report. \ No newline at end of file diff --git a/lib/plugins/crux/repackage.js b/lib/plugins/crux/repackage.js index d5b388959f..02c87ac6fc 100644 --- a/lib/plugins/crux/repackage.js +++ b/lib/plugins/crux/repackage.js @@ -11,15 +11,6 @@ export function repackage(cruxResult) { .density }; } - if (cruxResult.record.metrics.first_input_delay) { - result.FIRST_INPUT_DELAY_MS = { - p75: cruxResult.record.metrics.first_input_delay.percentiles.p75, - fast: cruxResult.record.metrics.first_input_delay.histogram[0].density, - moderate: - cruxResult.record.metrics.first_input_delay.histogram[1].density, - slow: cruxResult.record.metrics.first_input_delay.histogram[2].density - }; - } if (cruxResult.record.metrics.cumulative_layout_shift) { result.CUMULATIVE_LAYOUT_SHIFT_SCORE = {