Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect contact deletion #64

Open
esetnik opened this issue Feb 15, 2018 · 4 comments
Open

Detect contact deletion #64

esetnik opened this issue Feb 15, 2018 · 4 comments
Assignees

Comments

@esetnik
Copy link

esetnik commented Feb 15, 2018

For Deals there is an isdeleted flag but for Contacts there doesn't appear to be anything similar. How are we supposed to filter out contacts which have been deleted in Hubspot?

@briansloane briansloane self-assigned this Feb 20, 2018
@briansloane
Copy link
Contributor

@esetnik After doing some further research on the HubSpot API it looks like the only way to get information about deleted contacts is via webhooks. Unfortunately, the Singer tap works via polling the REST APIs. I don't see any clear ways to get something like an isdeleted value from the REST APIs.

One solution would be to wipe out the data and periodically do a full resync of contacts. That wouldn't give you an isdeleted flag but would at least eliminate any deleted contacts from the result set.

@esetnik
Copy link
Author

esetnik commented Feb 23, 2018

@briansloane I figured it wasn't possible. Since you are polling the REST APIs it looks like there's no way to do this unless you had access to the previous run of sync data. I suggest anyone else who would also like to see this feature should leave a comment on this question on Hubspot developer forums.

Additionally after further reviewing the Hubspot REST apis I found that isDeleted for deals is actually not a valid property so it won't work as intended. I suggest that we remove it from the tap to avoid confusion.

 "isDeleted": false,
  // Boolean; Whether or not the record is deleted. In practice this will always be false as deleted records will not appear in the API.

@wss-chadical
Copy link

@briansloane It hate to say it, but this is a major flaw in this tap. I know Hubspot is not making it easy for anyone to work with their api - but we need to figure out a way to get this built it in to this tap.

Does Stitch have some clout with hubspot to figure this out?

mdimercurio added a commit to dialoguemd-archives/tap-hubspot that referenced this issue Jun 1, 2019
* add calculation for LTV without ramp up

* add tests/doc

* fix indentation

* remove alias
@graydonclark
Copy link

Anyone ever figure this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants