Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will np start depending on GitHub’s autogen’d Release notes? #627

Closed
JaneJeon opened this issue Oct 5, 2021 · 3 comments
Closed

Will np start depending on GitHub’s autogen’d Release notes? #627

JaneJeon opened this issue Oct 5, 2021 · 3 comments

Comments

@JaneJeon
Copy link

JaneJeon commented Oct 5, 2021

https://github.blog/2021-10-04-beta-github-releases-improving-release-experience/

Even though it’s in public beta, the messages autogenerated by the release feature looks to be VERY good and a suitable replacement for np’s manual release note generation.

I think we should investigate potentially replacing np’s release note construction w/ this over time in order to keep the core simple.

@fregante
Copy link
Collaborator

fregante commented Feb 3, 2023

I also like them, it would help np shed all the code to generate the release notes.

The only drawback is that GitHub’s notes ignore raw commits and only include PRs.

This would also fix every notes-related issue, like:

@sindresorhus
Copy link
Owner

I don't like the GitHub autogenerated release notes at all. They asked for feedback publicly, got a lot, including from me, and they didn't improve the feature at all.

So I'm happy to add an option to not generate release notes for the people that prefer that, but I think np's notes are better in every way, so I have no plans to remove that part.

@fregante
Copy link
Collaborator

fregante commented Feb 3, 2023

I have no plans to remove that part.

Then no reason to integrate it here, 👍 also because I think it would require authentication with GitHub.

When I want to use their generator, I just select np’s notes and replace them with a click on GitHub.com

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants