Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for isValidSlpTxn #7

Open
jcramer opened this issue Nov 4, 2019 · 0 comments
Open

Add unit tests for isValidSlpTxn #7

jcramer opened this issue Nov 4, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@jcramer
Copy link
Contributor

jcramer commented Nov 4, 2019

This convenience method provides extra protection to the user by detecting and preventing some burn scenarios. Unit tests should be implemented in order to cover all of the scenarios where tokens could be accidentally burned.

The tests should include:

  • Does not allow token burns for any non-SLP transactions (implemented)
  • Does not allow burns for tokens of the same token ID (implemented)
  • Does not allow burns for tokens of other token IDs (not implemented)
  • Does not allow excessive burns for NFT1 parent when creating NFT1 child (not implemented)
@jcramer jcramer added the enhancement New feature or request label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant