Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Size for markers #4026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Dec 20, 2023

Closes #4024

This API was exposed but not propagated the the backend.

Notice that the default marker size was not the same in mpl and opengl.
That's something which have to be checked.

Changelog:

  • Markers now supports setSymbolSize

@vallsv vallsv added this to the Next release milestone Dec 20, 2023
src/silx/gui/plot/backends/BackendOpenGL.py Outdated Show resolved Hide resolved
@vallsv vallsv changed the title Size for markers Draft: Size for markers Dec 21, 2023
@vallsv
Copy link
Contributor Author

vallsv commented Dec 21, 2023

Changed as draft, i dont expect it to be merged.

@t20100
Copy link
Member

t20100 commented Dec 21, 2023

It's not a big PR and it fixes an issue, so it can go in 2.0 for me

@t20100
Copy link
Member

t20100 commented Dec 21, 2023

CI fails, let's keep this for later indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marker items have a setSymbolSize but it is not propagated
2 participants