Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display multiple profiles inside the same window #3919

Open
vallsv opened this issue Jul 28, 2023 · 0 comments
Open

Display multiple profiles inside the same window #3919

vallsv opened this issue Jul 28, 2023 · 0 comments
Assignees
@vallsv
Labels
enhancement
Milestone
Next release

Comments

@vallsv
Copy link
Contributor

vallsv commented Jul 28, 2023 •
edited
Loading

I have this feature to provide in Flint https://gitlab.esrf.fr/bliss/bliss/-/issues/3399

Sounds like it is not really easy to do with the actual silx API.

  • Because the manager does not import the window then a ROI is removed
  • Because the profile window was designed for a single profile

To make it possible mostly the ProfileWindow have to be refactored

  • A removeRoi have to be added
  • The roi have to be passed everytime a related data is updated
    • setProfile(data) -> setProfile(roi, data)

It's not a big deal but it will break thinks.

Optionally we could imagine a ProfileWindow2 with another API.
@vallsv vallsv changed the title Display multiple profiles insidee the same window Display multiple profiles inside the same window Jul 28, 2023
@vallsv vallsv added this to the Next release milestone Sep 8, 2023
@vallsv vallsv self-assigned this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vallsv vallsv

Labels
enhancement
Projects
None yet
Milestone
Next release
Development

No branches or pull requests
1 participant
@vallsv