Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HTMLEditorSanitiser with symfony/html-sanitizer #11377

Open
GuySartorelli opened this issue Sep 12, 2024 · 0 comments
Open

Replace HTMLEditorSanitiser with symfony/html-sanitizer #11377

GuySartorelli opened this issue Sep 12, 2024 · 0 comments

Comments

@GuySartorelli
Copy link
Member

We currently maintain a HTMLEditorSanitiser which is mostly responsible for two things:

  1. Ensuring only the markup allowed by the HTMLEditorConfig is included in the output
  2. Ensuring the output doesn't include XSS or other vulnerability attacks that can be included in HTML markup

Symfony have a symfony/html-sanitizer component that can do the same job, with the benefit that we don't have to maintain our own sanitizer and try to keep it up to date with all possible attack vectors.

See the docs for that component for more details about its usage.

Acceptance Criteria

  • Replace as much logic as we can from HTMLEditorSanitiser with Symfony's HtmlSanitizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant