Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-min_score does not work #50

Open
LeoYao opened this issue Jun 24, 2015 · 0 comments
Open

-min_score does not work #50

LeoYao opened this issue Jun 24, 2015 · 0 comments

Comments

@LeoYao
Copy link

LeoYao commented Jun 24, 2015

I am trying using "exist" keyword to check if a checkbox is checked or not. I found no matter what status the checkbox is in, sikuli-slide always return true as the result of "exist" action. I think it should be related to the similarity of the image, because I had similar issue in SikuliX and fixed it by increasing the similarity threshold to 0.95. However, I found even if I increased the threshold in Sikuli Slides by setting "-min_score" from 0.80 to 0.99 on command line, the result remains incorrect.

I checked the source code and I found a possible cause.
In org.sikuli.slides.api.sikuli.CrossSearchStrategy, there is some hardcode like below:

Target target = hypothesis.getTarget();
target.setMinScore(0.8f);

I tried changing 0.8f to 0.95f, and the result seems correct now. However, it seems there are lots of place not using min_score, such as ContextImageTarget.

I am wondering if the min_score is really in use or has not been implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant