Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify execution chain syncing #447

Open
jannikluhn opened this issue May 29, 2024 · 1 comment
Open

Unify execution chain syncing #447

jannikluhn opened this issue May 29, 2024 · 1 comment

Comments

@jannikluhn
Copy link
Contributor

jannikluhn commented May 29, 2024

In Gnosh, we use multiple execution chain state syncing implementations:

They contain similar logic, so we should unify them. chainsync is the most general purpose and has the additional feature of detecting reorgs, so we should try to integrate the other two into their framework. To do that, we probably want to make chainsync more abstract and allow "registering" syncers from the outside. Then we only have to make the validatorsyncer and sequencersyncer to implement the required interface.

@ezdac
Copy link
Collaborator

ezdac commented May 31, 2024

I would love to take this one, but with my limited dev-time I'm not sure if this is a fit in terms of delivery time.

By the way, I am currently working on merging the reorg aware chainsync features into the gnosis branch (#444).
In general I think the chainsync package evolved and now is somewhat bloated and hard to understand for what it does, so a refactoring could be beneficial in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants