Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any Other Feature #57

Open
seths10 opened this issue Oct 13, 2022 · 13 comments
Open

Any Other Feature #57

seths10 opened this issue Oct 13, 2022 · 13 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@seths10
Copy link
Owner

seths10 commented Oct 13, 2022

I'm accepting any other features that you may want to add to the repository

@seths10 seths10 added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 13, 2022
@burhanharoon
Copy link
Contributor

I would like to add a feature where a user can download the quote as an image. I think that would be great as some users want to download the quote and then they can share it anywhere else.

@Such6
Copy link

Such6 commented Oct 13, 2022

Can I add a feature of q quote shrinking and growing?

@seths10
Copy link
Owner Author

seths10 commented Oct 15, 2022

@Such6 go ahead and submit a valid PR, I will merge it.

@seths10
Copy link
Owner Author

seths10 commented Oct 15, 2022

@burhanharoon that will be very great, can wait to test it out. Go ahead,i will be waiting for a PR from you.

@burhanharoon
Copy link
Contributor

Sure!

@seths10
Copy link
Owner Author

seths10 commented Oct 16, 2022

I'm reviewing it, I will merge it soon

@burhanharoon
Copy link
Contributor

Sure!

@seths10
Copy link
Owner Author

seths10 commented Oct 18, 2022

@burhanharoon I've merged your pull request

@burhanharoon
Copy link
Contributor

Sounds great!

@ishita1805
Copy link
Contributor

@seths10 Not really a feature per say but what do you think about setting up github actions, husky and eslint for this repo?

@seths10
Copy link
Owner Author

seths10 commented Oct 25, 2022

@ishita1805 that sounds great

@ishita1805
Copy link
Contributor

@seths10 Here's my PR, lemme know what you think #168

@niikkhilsharma
Copy link

I think that's a great Idea to add a feature. But we also need to focus on the point that our code isn't fully organised and their are some other ES6 method that can be used for re-writing the code, so that we'll have higher chances of preventing errors and bug.
Thank You
@ishita1805 @seths10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants