Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Author Names #184

Open
seths10 opened this issue Oct 24, 2023 · 10 comments
Open

Add Missing Author Names #184

seths10 opened this issue Oct 24, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@seths10
Copy link
Owner

seths10 commented Oct 24, 2023

some of the quotes do not have any author, thus they've been dubbed anonymous. Please add the actual author to the particular author if you know his/her name.

@seths10 seths10 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 24, 2023
@MojoBoingo
Copy link
Contributor

MojoBoingo commented Oct 24, 2023

This an open issue or you looking for an assignee? Either way I'd like to work on it, researching the authors seems like a good low-code contribution. Pls assign me if that's how it goes.

@ChauhanHarshit
Copy link

hey i would like to contribute to this issue. please assign me.

@seths10
Copy link
Owner Author

seths10 commented Oct 25, 2023

I have assigned both of you to the task @ChauhanHarshit @MojoBoingo

@MojoBoingo
Copy link
Contributor

@seths10 👌

@MojoBoingo
Copy link
Contributor

MojoBoingo commented Oct 25, 2023

hey @seths10 I'm finding a lot of duplicate quotes just among the ones with anon authors. They are the only ones I'm looking at for the moment, but it's prevalent enough I doubt it's just these. I'm noting the ones I see for deletion, can include that in the PR or not. For now I'm just leaving a comment next to duplicates in the code.

@seths10
Copy link
Owner Author

seths10 commented Oct 25, 2023

you can help fix it

@MojoBoingo
Copy link
Contributor

deleting duplicates could be a good issue for someone :)

@seths10
Copy link
Owner Author

seths10 commented Oct 25, 2023

removing duplicates is already an issue

@MojoBoingo
Copy link
Contributor

yeah I realized that. I haven't begun learning JS proper yet so I'll leave writing a script to someone else who needs another PR in the next 6 days. I'd be mostly doing it manually. I am leaving a comment denoting each duplicate I found though. Working on my branch as we speak, will push p soon.

@MojoBoingo
Copy link
Contributor

@seths10 PR sent, found 12 quotes an author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants