From be0b854fd237b32b8efe2b63405eb3e6c468ead1 Mon Sep 17 00:00:00 2001 From: Findeton Date: Wed, 6 Sep 2023 14:30:13 -0500 Subject: [PATCH 01/23] wip --- avAdmin/admin-directives/dashboard/dashboard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avAdmin/admin-directives/dashboard/dashboard.js b/avAdmin/admin-directives/dashboard/dashboard.js index 4bacdecb..70ab7778 100644 --- a/avAdmin/admin-directives/dashboard/dashboard.js +++ b/avAdmin/admin-directives/dashboard/dashboard.js @@ -673,7 +673,7 @@ angular.module('avAdmin') .getEditPerm(scope.id) .then( function (perm) { - scope.perms.val = perm; + scope.perms.val = perm.split(":")[4].split("|"); } ); scope.publicURL = ConfigService.publicURL; From bcc48a591e47d5af78650a7628a9267968a6be3e Mon Sep 17 00:00:00 2001 From: Findeton Date: Wed, 6 Sep 2023 15:09:14 -0500 Subject: [PATCH 02/23] wip --- avAdmin/init.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/avAdmin/init.js b/avAdmin/init.js index 98cd5d19..f869407f 100644 --- a/avAdmin/init.js +++ b/avAdmin/init.js @@ -17,6 +17,17 @@ angular.module('avAdmin', ['ui.bootstrap','ui.utils','ui.router']); -angular.module('avAdmin').config(function() { +angular.module('avAdmin').config(function($scope, ElectionsApi) { /* Add New States Above */ + var perms = {val: ""}; + ElectionsApi + .getEditPerm(scope.id) + .then( + function (perm) { + perms.val = perm.split(":")[4].split("|"); + } + ); + angular.extend($scope, { + perms: perms + }); }); From d301cb70ed06e97803d2aa2b9489c8ff5b986f2d Mon Sep 17 00:00:00 2001 From: Findeton Date: Wed, 6 Sep 2023 15:31:18 -0500 Subject: [PATCH 03/23] wip --- avAdmin/admin-controller/admin-controller.js | 20 +++++++++++++++---- .../admin-directives/dashboard/dashboard.js | 2 ++ avAdmin/init.js | 14 +------------ 3 files changed, 19 insertions(+), 17 deletions(-) diff --git a/avAdmin/admin-controller/admin-controller.js b/avAdmin/admin-controller/admin-controller.js index 80fa0f26..0a3da48c 100644 --- a/avAdmin/admin-controller/admin-controller.js +++ b/avAdmin/admin-controller/admin-controller.js @@ -38,9 +38,6 @@ angular var id = $stateParams.id; $scope.electionId = id; - // get election perms, with a default of no perms - $scope.perms = {val: ""}; - $scope.state = $state.current.name; $scope.current = null; $scope.noplugin = true; @@ -219,16 +216,31 @@ angular Plugins.hook('add-dashboard-election-states', plugins_data); states = states.concat(plugins_data.states); + + // get election perms, with a default of no perms + $scope.perms = {val: ""}; + ElectionsApi + .getEditPerm($scope.electionId) + .then( + function (perm) { + $scope.perms.val = perm.split(":")[4].split("|"); + } + ); + $scope.globalPerms = {val: ""}; // update global perms ElectionsApi .getEditPerm(null) .then( function (perm) { - $scope.globalPerms.val = perm; + $scope.globalPerms.val = perm.split(":")[4].split("|"); } ); + angular.extend($scope, { + perms: $scope. + }) + if (states.indexOf($scope.state) >= 0) { $scope.sidebarlinks = []; if (!!id) diff --git a/avAdmin/admin-directives/dashboard/dashboard.js b/avAdmin/admin-directives/dashboard/dashboard.js index 70ab7778..e5362627 100644 --- a/avAdmin/admin-directives/dashboard/dashboard.js +++ b/avAdmin/admin-directives/dashboard/dashboard.js @@ -668,6 +668,7 @@ angular.module('avAdmin') $state.go("admin.basic"); } + /* scope.perms = {val: ""}; ElectionsApi .getEditPerm(scope.id) @@ -676,6 +677,7 @@ angular.module('avAdmin') scope.perms.val = perm.split(":")[4].split("|"); } ); + */ scope.publicURL = ConfigService.publicURL; scope.launchedTally = false; diff --git a/avAdmin/init.js b/avAdmin/init.js index f869407f..a45901d4 100644 --- a/avAdmin/init.js +++ b/avAdmin/init.js @@ -17,17 +17,5 @@ angular.module('avAdmin', ['ui.bootstrap','ui.utils','ui.router']); -angular.module('avAdmin').config(function($scope, ElectionsApi) { - /* Add New States Above */ - var perms = {val: ""}; - ElectionsApi - .getEditPerm(scope.id) - .then( - function (perm) { - perms.val = perm.split(":")[4].split("|"); - } - ); - angular.extend($scope, { - perms: perms - }); +angular.module('avAdmin').config(function() { }); From 703acb2188a2e12777eedd426135da59f3e9b5fd Mon Sep 17 00:00:00 2001 From: Findeton Date: Wed, 6 Sep 2023 15:33:29 -0500 Subject: [PATCH 04/23] wip --- avAdmin/admin-controller/admin-controller.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/avAdmin/admin-controller/admin-controller.js b/avAdmin/admin-controller/admin-controller.js index 0a3da48c..76507526 100644 --- a/avAdmin/admin-controller/admin-controller.js +++ b/avAdmin/admin-controller/admin-controller.js @@ -237,10 +237,6 @@ angular } ); - angular.extend($scope, { - perms: $scope. - }) - if (states.indexOf($scope.state) >= 0) { $scope.sidebarlinks = []; if (!!id) From 5315d9a24314b333177dbd5b783783dcd87d2178 Mon Sep 17 00:00:00 2001 From: Findeton Date: Wed, 6 Sep 2023 15:38:38 -0500 Subject: [PATCH 05/23] wip --- avAdmin/admin-directives/dashboard/dashboard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avAdmin/admin-directives/dashboard/dashboard.js b/avAdmin/admin-directives/dashboard/dashboard.js index e5362627..2010d1a0 100644 --- a/avAdmin/admin-directives/dashboard/dashboard.js +++ b/avAdmin/admin-directives/dashboard/dashboard.js @@ -1355,7 +1355,7 @@ angular.module('avAdmin') return { restrict: 'AE', - scope: {}, + scope: true, link: link, templateUrl: 'avAdmin/admin-directives/dashboard/dashboard.html' }; From cc9b7ea8be9ed339a73258b8613b17fd31b668f8 Mon Sep 17 00:00:00 2001 From: Findeton Date: Wed, 6 Sep 2023 15:51:05 -0500 Subject: [PATCH 06/23] wip --- avAdmin/admin-controller/admin-controller.js | 1 - .../admin-sidebar-directive/admin-sidebar-directive.js | 10 ---------- 2 files changed, 11 deletions(-) diff --git a/avAdmin/admin-controller/admin-controller.js b/avAdmin/admin-controller/admin-controller.js index 76507526..2183cd6f 100644 --- a/avAdmin/admin-controller/admin-controller.js +++ b/avAdmin/admin-controller/admin-controller.js @@ -266,7 +266,6 @@ angular if ( perm.indexOf('event-view-activity') !== -1 || - perm.indexOf('view') !== -1 || perm.indexOf('edit') !== -1 ) { $scope.sidebarlinks = $scope.sidebarlinks.concat([ diff --git a/avAdmin/admin-sidebar-directive/admin-sidebar-directive.js b/avAdmin/admin-sidebar-directive/admin-sidebar-directive.js index 5cd03c87..41dfdd96 100644 --- a/avAdmin/admin-sidebar-directive/admin-sidebar-directive.js +++ b/avAdmin/admin-sidebar-directive/admin-sidebar-directive.js @@ -46,16 +46,6 @@ angular.module('avAdmin') scope.isAdmin = $cookies.get("isAdmin" + postfix); scope.active = attrs.active; scope.isEditingDraft = DraftElection.isEditingDraft; - scope.globalPerms = { val: '' }; - - // update perms - ElectionsApi - .getEditPerm(null) - .then( - function (perm) { - scope.globalPerms.val = perm; - } - ); } return { From 739dde6bc5116613bc5924c421355107d9f9e28b Mon Sep 17 00:00:00 2001 From: Findeton Date: Wed, 6 Sep 2023 16:04:24 -0500 Subject: [PATCH 07/23] wip --- avAdmin/admin-directives/elbasic/elbasic.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/avAdmin/admin-directives/elbasic/elbasic.js b/avAdmin/admin-directives/elbasic/elbasic.js index b1a9e733..2c55a3b1 100644 --- a/avAdmin/admin-directives/elbasic/elbasic.js +++ b/avAdmin/admin-directives/elbasic/elbasic.js @@ -30,7 +30,10 @@ angular.module('avAdmin') scope.layouts = ['simple', /*'2questions-conditional', 'pcandidates-election'*/]; scope.themes = ['default'/*, 'podemos'*/]; - scope.allow_social_edit = ConfigService.share_social.allow_edit; + scope.allow_social_edit = ConfigService.share_social.allow_edit && ( + scope.perms.val.indexOf("edit") !== -1 || + scope.perms.val.indexOf("update-share") !== -1 + ); scope.electionEditable = function() { return !scope.election.id || scope.election.status === "registered"; @@ -74,8 +77,7 @@ angular.module('avAdmin') return { restrict: 'AE', - scope: { - }, + scope: true, link: link, templateUrl: 'avAdmin/admin-directives/elbasic/elbasic.html' }; From 35fb846cd3c8e59656126ca65bc5eaebcdcc33e8 Mon Sep 17 00:00:00 2001 From: Findeton Date: Fri, 8 Sep 2023 14:43:57 -0500 Subject: [PATCH 08/23] wip --- avAdmin/admin-controller/admin-controller.js | 2 +- avAdmin/admin-directives/dashboard/dashboard.js | 10 ---------- avAdmin/admin-directives/elcensus/elcensus.js | 12 +----------- 3 files changed, 2 insertions(+), 22 deletions(-) diff --git a/avAdmin/admin-controller/admin-controller.js b/avAdmin/admin-controller/admin-controller.js index 2183cd6f..0bb345e4 100644 --- a/avAdmin/admin-controller/admin-controller.js +++ b/avAdmin/admin-controller/admin-controller.js @@ -275,7 +275,7 @@ angular // update election perms - $scope.perms.val = perm; + $scope.perms.val = perm.split(":")[4].split("|"); } ); } diff --git a/avAdmin/admin-directives/dashboard/dashboard.js b/avAdmin/admin-directives/dashboard/dashboard.js index 2010d1a0..95f73bf1 100644 --- a/avAdmin/admin-directives/dashboard/dashboard.js +++ b/avAdmin/admin-directives/dashboard/dashboard.js @@ -668,16 +668,6 @@ angular.module('avAdmin') $state.go("admin.basic"); } - /* - scope.perms = {val: ""}; - ElectionsApi - .getEditPerm(scope.id) - .then( - function (perm) { - scope.perms.val = perm.split(":")[4].split("|"); - } - ); - */ scope.publicURL = ConfigService.publicURL; scope.launchedTally = false; diff --git a/avAdmin/admin-directives/elcensus/elcensus.js b/avAdmin/admin-directives/elcensus/elcensus.js index db722636..03f346a7 100644 --- a/avAdmin/admin-directives/elcensus/elcensus.js +++ b/avAdmin/admin-directives/elcensus/elcensus.js @@ -49,15 +49,6 @@ angular.module('avAdmin') scope.nomore = false; scope.error = null; scope.page = 1; - - scope.perms = {val: ""}; - ElectionsApi - .getEditPerm(scope.election.id) - .then( - function (perm) { - scope.perms.val = perm; - } - ); scope.msg = null; scope.filterStr = ""; @@ -1207,8 +1198,7 @@ angular.module('avAdmin') return { restrict: 'AE', - scope: { - }, + scope: true, link: link, templateUrl: 'avAdmin/admin-directives/elcensus/elcensus.html' }; From 9a0349b76872eb59d3f4d7a95fbdbf50a82a175a Mon Sep 17 00:00:00 2001 From: Findeton Date: Fri, 8 Sep 2023 14:57:02 -0500 Subject: [PATCH 09/23] wip --- avAdmin/admin-directives/dashboard/dashboard.html | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/avAdmin/admin-directives/dashboard/dashboard.html b/avAdmin/admin-directives/dashboard/dashboard.html index 3aa59005..dabe5e86 100644 --- a/avAdmin/admin-directives/dashboard/dashboard.html +++ b/avAdmin/admin-directives/dashboard/dashboard.html @@ -23,7 +23,7 @@