Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #1639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Version Packages #1639

wants to merge 1 commit into from

Conversation

seek-oss-ci
Copy link
Contributor

@seek-oss-ci seek-oss-ci commented Aug 23, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Major Changes

  • lint: Migrate to ESLint 9 and @typescript-eslint 8. (#1537)

    These changes may affect your project setup if customising your ESLint configuration. See the individual migration guides:

    In addition, through these major upgrades, some lint rules have changed or have been renamed. You will likely need adjust your code after running ESLint.

    Furthermore, eslint-plugin-import has been replaced with eslint-plugin-import-x. To migrate, any references to eslint-plugin-import should be replaced with eslint-plugin-import-x, and import/ rules with import-x/.

    As part of this migration, skuba has migrated to using Flat ESLint configuration. Read the migration: https://eslint.org/docs/latest/use/configure/migration-guide.

    skuba format will attempt to migrate to flat configuration for you, where .eslintignore and .eslintrc are replaced by eslint.config.js.

  • node, start: Replace ts-node with tsx (#1623)

    skuba start and skuba node now use tsx instead of ts-node for running TypeScript files. tsx has better ESM interoperability, like support for dynamic imports (await import()), than ts-node.

    There are some downsides for the REPL (which is what skuba node without any file is):

    • import statements in the REPL are not supported; require and await import() are still supported.
    • Pasting code into the REPL may not work as well as ts-node. If encountering issues, a workaround could be to use .editor

    Otherwise, skuba start and skuba node <file> should work as expected. However, it is difficult to comprehensively test every scenario, so this has been released as a major version. It is recommended to test your use-cases of skuba start and skuba node after upgrading.

Minor Changes

  • lint: Update Docker base images to point to AWS ECR Public and remove redundant --platform usage (#1684)

    This updates references to node: or python: Docker images in your Dockerfile and docker-compose.yml files to point to AWS ECR Public to avoid Docker Hub rate limiting, along with removing redundant --platform usage.

    eg.

    ## Before
    FROM --platform=arm64 node:20-alpine AS dev-deps
    
    ## After
    FROM public.ecr.aws/docker/library/node:20-alpine AS dev-deps
  • lint: Removes obsolete version field from docker-compose.yml files (#1638)

  • deps: TypeScript 5.6 (#1655)

    This major release includes breaking changes. See the TypeScript 5.6 announcement for more information.

  • lint: Replace .buildkite/ files with duplicated YAML merge keys, for example: (#1537)

    # Before
    - <<: *deploy
      <<: *docker
      label: stuff
    
    # After
    - <<: [*deploy, *docker]
      label: stuff

    This should have no functional change, and is to support standardised YAML parsing across different tools, including the latest ESLint upgrades.

    This migration will not be capture all cases of this (e.g. if there are keys between the merge keys). If you have other cases, update them following the example above.

  • template/lambda-sqs-worker-cdk: Replace custom hooks with @seek/aws-codedeploy-infra (#1644)

  • lint, format: Remove logic which skips autofixing Renovate branches when there is no open pull request. (#1687)

    Previously, this was put in place to prevent an issue where a Renovate branch can get stuck in the Edited/Blocked state without a pull request being raised.

    Skuba's default autofix commits are now ignored by skuba's recommended renovate configuration.

Patch Changes

  • template/koa-rest-api: Enable secure headers middleware by default (#1601)

  • template: Add required tags to lambda-sqs-worker-cdk template (#1643)

  • api: Truncate Buildkite annotations over 1 MiB to resolve buildkite-agent crash (#1645)

  • deps: validate-npm-package-name ^6.0.0 (#1682)

  • deps: normalize-package-data ^7.0.0 (#1681)

  • deps: esbuild ~0.24.0 (#1671)

  • deps: concurrently ^9.0.0 (#1666)

  • template/*: Update Docker base images to point to AWS ECR Public and remove redundant --platform usage (#1684)

[email protected]

Major Changes

Minor Changes

  • Disable @typescript-eslint/only-throw-error in test files (#1689)

@seek-oss-ci seek-oss-ci requested a review from a team as a code owner August 23, 2024 02:03
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 4 times, most recently from 4511168 to 99f5f62 Compare September 2, 2024 01:15
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 11 times, most recently from 01ee83c to eab359c Compare September 10, 2024 05:53
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 7 times, most recently from bb3cced to 3c7543e Compare September 15, 2024 23:23
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 7 times, most recently from 4b87e13 to c2d28a1 Compare September 23, 2024 16:32
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 14 times, most recently from 36638af to ca29867 Compare September 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant