Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: Review async local storage use #1064

Open
72636c opened this issue Dec 11, 2022 · 0 comments
Open

template: Review async local storage use #1064

72636c opened this issue Dec 11, 2022 · 0 comments

Comments

@72636c
Copy link
Member

72636c commented Dec 11, 2022

Our Koa template is still using a seek-koala export that can be easy to misuse as per seek-oss/koala#171:

import { RequestLogging } from 'seek-koala';
import { config } from 'src/config';
const { createContextMiddleware, mixin } =
RequestLogging.createContextStorage();
export const contextMiddleware = createContextMiddleware();

It looks like koajs/koa#1721 adds some built-in functionality that we can investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant