Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: publish a Docker image with the CLI #1296

Open
2 tasks done
jaguililla opened this issue Jun 6, 2024 · 4 comments
Open
2 tasks done

Feature: publish a Docker image with the CLI #1296

jaguililla opened this issue Jun 6, 2024 · 4 comments

Comments

@jaguililla
Copy link

Feature request

As a software developer,
I want to use a SDKMAN CLI image as a base for a CI job,
in order to avoid managing different images for each JDK version

Currently, you need to update the CI runners' images if you switch your application's Java version (you have to deal with Java version in two places).

If a SDKMAN image is published in hub.docker.com, you would only need to handle the JDK version on your repository .sdkmanrc file. Thus making easier the change of java versions, and the runner images management (as developers won't require CI jobs to be changed).

It will also assist you beyond that as you could also install other candidates (as for example Kotlin) without creating another CI image.

Finally, it would be great to also allow to change the candidates directory in order to make caching possible on most CI platforms.

The steps to make this possible would be:

  1. Create a Dockerfile with the CLI installed
  2. Build the image on GitHub actions on PRs
  3. Push the image to hub.docker.com on each release
@marc0der
Copy link
Member

Hi @jaguililla, I've often thought about having an official docker image on Docker Hub but I've never gotten around to it.

As always, time is limited so I don't have capacity to do it myself. However, I'd gladly accept a contribution to get this done.

@jaguililla
Copy link
Author

It will probably take me some time, but I can work on this.

Should I add the Docker file in this same repository?

@marc0der
Copy link
Member

marc0der commented Jun 11, 2024

I'd suggest starting a new repo for this under your own account. Once you get it working, we could transfer it to the SDKMAN organisation and wire it up with webhooks and appropriate credentials.

Its workflow would need to be triggered by multiple repos in our org.

@jaguililla
Copy link
Author

Ok, I'll work on it (you can assign this task to me). However, It will take me time to complete it as I'm also working in other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants