Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify 'transaction' struct #888

Open
lispc opened this issue Sep 3, 2023 · 0 comments
Open

simplify 'transaction' struct #888

lispc opened this issue Sep 3, 2023 · 0 comments
Labels

Comments

@lispc
Copy link

lispc commented Sep 3, 2023

Describe the feature you would like

there are too many Transaction struct.

eth_types::geth_types::Transaction
ethers_core::types::transaction::response::Transaction
mock::transaction::MockTransaction

we have methods like


impl From<MockTransaction> for GethTransaction {
    fn from(mock: MockTransaction) -> Self {
        GethTransaction::from(&Transaction::from(mock))
    }
}

Additional context

No response

@lispc lispc added the refactor label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant