You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issues are different though: the zyte-common-items code looks for HasMetadata and doesn't find it while the web-poet code looks just for some GenericAlias and in this testcase finds the wrong one.
Not sure what is the correct implementation here as the current code handles all kinds of generic base classes, including ItemPage, WebPage, Returns, Extractor etc. All of them descend from Returns though, so maybe we should check the class with isinstance, not for equality.
Similar to zytedata/zyte-common-items#49, even though the code is different, it's also not recursive and fails on e.g. this:
The text was updated successfully, but these errors were encountered: