Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report for EitherMappableFuture in sbt-coverage-samples is wrong #296

Open
unkarjedy opened this issue Oct 23, 2020 · 1 comment
Open

report for EitherMappableFuture in sbt-coverage-samples is wrong #296

unkarjedy opened this issue Oct 23, 2020 · 1 comment

Comments

@unkarjedy
Copy link

open https://github.com/scoverage/sbt-scoverage-samples
run clean ; cleanFiles ; coverage ; test ; coverageReport

see report for com.sksamuel.scoverage.samples.EitherMappableFuture

image

case Left(e) => Future.failed(e) is never being called (can test it by adding new Error("oops") to the branch)
but report doesn't highlight it with red

@ckipp01
Copy link
Member

ckipp01 commented May 11, 2021

Thanks for reporting @unkarjedy. The sbt-coverage-samples is pretty wildly outdated. I'll leave this open for now, but first I'd like to get that repo possibly up-to-date before to see if this issue still actually exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants