Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: remove redundant dispatched_port_start/end configuration option from router config .toml #4544

Open
matzf opened this issue Jun 10, 2024 · 0 comments
Labels
workitem Something needs doing

Comments

@matzf
Copy link
Contributor

matzf commented Jun 10, 2024

Follow up from #4344 (review)

The "dispatch ports" range is configured in the topology.json file, but can be overridden from the router configuration .toml.

Having two sources for one configuration value complicates things, both for the user and the implementation.
In this case, it appears that the override in the router configuration is used in an acceptance test only. Find a different way to run this acceptance test, and remove the flag from the configuration.

@matzf matzf added the workitem Something needs doing label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workitem Something needs doing
Projects
None yet
Development

No branches or pull requests

1 participant