Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] RCA should maybe be in "Supervised algorithms" #237

Open
wdevazelhes opened this issue Jul 23, 2019 · 2 comments
Open

[DOC] RCA should maybe be in "Supervised algorithms" #237

wdevazelhes opened this issue Jul 23, 2019 · 2 comments

Comments

@wdevazelhes
Copy link
Member

Currently RCA is in Pairs Learners in the doc, where it shouldn't. It should probably be in "Supervised"

@bellet
Copy link
Member

bellet commented Jul 29, 2019

I agree it shouldn't be in pairs learners. It is not supervised either though (only need to know that groups of points share the same label, not the label itself). We could put it there if we do not want to create a new section in the doc for learning from chunklets (which will contain only RCA).

@bellet
Copy link
Member

bellet commented Jan 20, 2020

Note also that we are currently inconsistent as RCA appears under Supervised Learning Algorithms in the Package Contents section f the doc:
http://contrib.scikit-learn.org/metric-learn/metric_learn.html#supervised-learning-algorithms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants