diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 7359a989c0..0fe147c346 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -27,7 +27,7 @@ repos: exclude: ^validation/|\.dtd$|\.xml$ - repo: https://github.com/astral-sh/ruff-pre-commit - rev: "v0.0.281" + rev: "v0.0.287" hooks: - id: ruff args: ["--fix", "--show-fixes"] @@ -38,13 +38,13 @@ repos: - id: black-jupyter - repo: https://github.com/adamchainz/blacken-docs - rev: 1.15.0 + rev: 1.16.0 hooks: - id: blacken-docs additional_dependencies: [black==23.7.0] - repo: https://github.com/pre-commit/mirrors-mypy - rev: v1.4.1 + rev: v1.5.1 # check the oldest and newest supported Pythons hooks: - &mypy @@ -62,7 +62,7 @@ repos: rev: 1.7.0 hooks: - id: nbqa-ruff - additional_dependencies: [ruff==0.0.281] + additional_dependencies: [ruff==0.0.287] args: ["--extend-ignore=F821,F401,F841,F811"] - repo: https://github.com/codespell-project/codespell diff --git a/src/pyhf/parameters/paramsets.py b/src/pyhf/parameters/paramsets.py index c5daebf034..2562c89305 100644 --- a/src/pyhf/parameters/paramsets.py +++ b/src/pyhf/parameters/paramsets.py @@ -30,7 +30,7 @@ def __init__(self, **kwargs): @property def suggested_fixed(self) -> List[bool]: - if type(self._suggested_fixed) == bool: + if isinstance(self._suggested_fixed, bool): return [self._suggested_fixed] * self.n_parameters return self._suggested_fixed @@ -47,11 +47,9 @@ def suggested_fixed_as_bool(self) -> bool: @suggested_fixed.setter def suggested_fixed(self, value): - if type(value) == bool: - self._suggested_fixed = value - else: + if not isinstance(value, bool): assert len(value) == self.n_parameters - self._suggested_fixed = value + self._suggested_fixed = value class unconstrained(paramset): diff --git a/src/pyhf/readxml.py b/src/pyhf/readxml.py index d1942bfe4e..a694dab292 100644 --- a/src/pyhf/readxml.py +++ b/src/pyhf/readxml.py @@ -340,7 +340,9 @@ def process_measurements( other_parameter_configs = other_parameter_configs if other_parameter_configs else [] for x in toplvl.findall('Measurement'): - parameter_configs_map: MutableMapping[str, Parameter] = {k['name']: dict(**k) for k in other_parameter_configs} # type: ignore[misc] + parameter_configs_map: MutableMapping[str, Parameter] = { + k['name']: dict(**k) for k in other_parameter_configs + } lumi = float(x.attrib['Lumi']) lumierr = lumi * float(x.attrib['LumiRelErr'])