diff --git a/lib/Optimizer/Dialect/CC/CCOps.cpp b/lib/Optimizer/Dialect/CC/CCOps.cpp index 73660a6191..9bfe2b4e4a 100644 --- a/lib/Optimizer/Dialect/CC/CCOps.cpp +++ b/lib/Optimizer/Dialect/CC/CCOps.cpp @@ -379,8 +379,9 @@ struct FuseCastCascade : public OpRewritePattern { // %5 = cc.cast %3 : (!cc.ptr) -> !cc.ptr rewriter.replaceOpWithNewOp(castOp, castOp.getType(), castToCast.getValue()); + return success(); } - return success(); + return failure(); } }; @@ -406,11 +407,13 @@ struct SimplifyIntegerCompare : public OpRewritePattern { auto rhsVal = rhsCast.getValue(); if (lhsVal.getType() == rhsVal.getType() && lhsCast.getSint() == rhsCast.getSint() && - lhsCast.getZint() == rhsCast.getZint()) + lhsCast.getZint() == rhsCast.getZint()) { rewriter.replaceOpWithNewOp( compare, compare.getType(), compare.getPredicate(), lhsVal, rhsVal); + return success(); + } } - return success(); + return failure(); } }; @@ -429,8 +432,9 @@ struct FuseComplexCreate : public OpRewritePattern { auto arrAttr = rewriter.getArrayAttr({rePart, imPart}); rewriter.replaceOpWithNewOp( create, ComplexType::get(eleTy), arrAttr); + return success(); } - return success(); + return failure(); } }; } // namespace @@ -764,7 +768,7 @@ struct FuseAddressArithmetic return success(); } } - return success(); + return failure(); } }; } // namespace @@ -967,7 +971,7 @@ struct FuseWithConstantArray return success(); } } - return success(); + return failure(); } }; } // namespace @@ -1058,8 +1062,9 @@ struct ForwardStdvecInitData Value cast = rewriter.create( data.getLoc(), data.getType(), ini.getBuffer()); rewriter.replaceOp(data, cast); + return success(); } - return success(); + return failure(); } }; } // namespace @@ -1085,8 +1090,9 @@ struct ForwardStdvecInitSize Value cast = rewriter.create( size.getLoc(), size.getType(), ini.getLength()); rewriter.replaceOp(size, cast); + return success(); } - return success(); + return failure(); } }; } // namespace @@ -1507,9 +1513,9 @@ struct HoistLoopInvariantArgs : public OpRewritePattern { } } } + return success(); } - - return success(); + return failure(); } }; } // namespace @@ -1640,7 +1646,7 @@ struct EraseScopeWhenNotNeeded : public OpRewritePattern { LogicalResult matchAndRewrite(cudaq::cc::ScopeOp scope, PatternRewriter &rewriter) const override { if (scope.hasAllocation()) - return success(); + return failure(); // scope does not allocate, so the region can be inlined into the parent. auto loc = scope.getLoc(); @@ -2149,8 +2155,9 @@ struct ReplaceInLoop : public OpRewritePattern { rewriter.splitBlock(scopeBlock, scopePt); rewriter.setInsertionPointToEnd(scopeBlock); rewriter.replaceOpWithNewOp(fromOp, fromOp.getOperands()); + return success(); } - return success(); + return failure(); } }; diff --git a/lib/Optimizer/Dialect/Quake/QuakeOps.cpp b/lib/Optimizer/Dialect/Quake/QuakeOps.cpp index 3b1407af40..a3c6373320 100644 --- a/lib/Optimizer/Dialect/Quake/QuakeOps.cpp +++ b/lib/Optimizer/Dialect/Quake/QuakeOps.cpp @@ -443,11 +443,13 @@ struct ForwardConcatExtractPattern auto index = extract.getConstantIndex(); if (index < concatQubits.size()) { auto qOpValue = concatQubits[index]; - if (isa(qOpValue.getType())) + if (isa(qOpValue.getType())) { rewriter.replaceOp(extract, {qOpValue}); + return success(); + } } } - return success(); + return failure(); } };