Providing nodeExecCommand setting

[ptrdom]

This is somewhat related to #418 - instead of directly supporting some node version manager, we could expose a setting that would allow users to set a node executable, similar to how sbt-native-packager does it with dockerExecCommand. Then users of scalajs-bundler could wire in for example https://github.com/jasongin/nvs by setting nodeExecCommand to nvs exec <ver>.

How does this sound @sjrd?

[sjrd]

This is something that can be done with a custom NodeJSEnv.Config:

import org.scalajs.jsenv.nodejs.NodeJSEnv

jsEnv := {
  new NodeJSEnv(NodeJSEnv.Config()
    .withExecutable("nvs")
    .withArgs(List("exec", ver)))
}

[ptrdom]

When suggesting this I mainly had interactions with Webpack in mind:

• scalajs-bundler/sbt-scalajs-bundler/src/main/scala/scalajsbundler/Webpack.scala

  Line 285 in d083e6d

  val cmd = "node" +: params

• scalajs-bundler/sbt-scalajs-bundler/src/main/scala/scalajsbundler/WebpackDevServer.scala

  Line 54 in d083e6d

  "node",

  
  It is not possible to intercept node executable used for them.

[sjrd]

Wouldn't that be possible to do in user space using #420, then?

[ptrdom]

No, because that PR does not expose these bundler related node invocations that I have linked above. New setting is the only way. Do not see a problem here - it is a beneficial change that is easily backwards compatible.