Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck errors reported when opening Play 2.4 views #249

Open
dotta opened this issue Jun 8, 2015 · 1 comment
Open

Typecheck errors reported when opening Play 2.4 views #249

dotta opened this issue Jun 8, 2015 · 1 comment
Labels

Comments

@dotta
Copy link
Member

dotta commented Jun 8, 2015

See https://groups.google.com/forum/#!topic/scala-ide-user/WFNoQ6GNw1k

@dotta dotta added the bug label Jun 8, 2015
dotta added a commit to dotta/scala-ide-play2 that referenced this issue Jun 12, 2015
This commit outlines how I believe we should attempt to fix issue scala-ide#249.

The one thing that is really missing is attaching a listener to the property
store to update the value of `PlayProject.playVersion`. The idea is that in
`CompilerUsingi.compileTemplateToScalaVirtual` we can use
`Play.apply(playProject.playVersion)` to retrieve an instance of `Play` that can
be used to inject the proper imports.

Note that the new classes are poorly named (hence they can and should be
changed). And also the current design isn't great, so it can be changed as well.
dotta added a commit to dotta/scala-ide-play2 that referenced this issue Jun 14, 2015
This commit outlines how I believe we should attempt to fix issue scala-ide#249.
@ghost
Copy link

ghost commented Sep 15, 2015

Upvote, I was following the google thread, tried Mirco's solution and I'm still using it, it is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant