Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind cookies to app-year. #300

Open
timparenti opened this issue Apr 3, 2019 · 2 comments
Open

Bind cookies to app-year. #300

timparenti opened this issue Apr 3, 2019 · 2 comments

Comments

@timparenti
Copy link
Contributor

Beyond the hotfix in #299, the application should be configured to change how cookies are stored should change with each app-year. It is not sufficient to simply use Date.current.year or similar in the cookie name, since the main problem manifests when users log in shortly before the app is re-seeded each April, at which point user IDs change while the cookies do not. However, there are many relevant timestamps in the database that could potentially help signal the year the app was built for.

Additionally, look into the possibility of storing more than just the user ID number in the cookie, to help detect when a cookie should go stale.

@timparenti
Copy link
Contributor Author

Other potential solutions:

@timparenti
Copy link
Contributor Author

Per today's meeting, once #294 is merged to keep participants bound to the same participant ID from year to year, this becomes far less of a problem.

Still, it's good hygiene to rotate the SECRET_KEY_BASE environment variable in /etc/apache2/sites-enabled/003-binder-app-production.conf when launching a new year's Carnival.

@Aklaran can add this to Carnival creation documentation in #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant