Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement loading spinner in question form #191

Open
18chowdhary opened this issue Apr 13, 2022 · 0 comments
Open

Implement loading spinner in question form #191

18chowdhary opened this issue Apr 13, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@18chowdhary
Copy link
Collaborator

Description

The Question Form takes a very long time to load - so long that it is noticeable to users and confuses them. To reduce this confusion, we tried to implement a loading spinner in the Question Form that displays while the questions are being set-up so that the user is informed that the questions are loading. However, we were not able to finalize the implementation of the loading spinner - specifically, the CountyDropdown causes an infinite re-render loop that makes the app crash. Through debugging, we have determined the issue may not be in the CountyDropdown; on the dev branch, which has the QuestionForm as a functional component without a loading spinner, the CountyDropdown renders without any issues. However, when the QuestionForm is turned into a class component with a loading spinner, the CountyDropdown does not render successfully. The CountyDropdown is identical in each branch.

Next Steps

  • Compare dev and fix/18chowdhary/fix-question-lagging for any other differences.
  • Perhaps consider turning QuestionForm in fix/18chowdhary/fix-question-lagging branch into a functional component with a loading spinner to determine if the issue may be turning QuesionForm into a class component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant